Review main Merged

73314[TASK] Remove PHP 8.0 and PHP 8.1 polyfills from ext:core

Stefan Bürk CR +2 V +2 Easy +0 −2 updated 02/07/22, 08:16

Commit message

With #96749 superflous polyfills has been removed from root
composer.json. This patch removes missed occurrences in the
composer.json of ext:core.

used command:

> composer rem symfony/polyfill-php80 -d typo3/sysext/core \
  --no-update
> composer rem symfony/polyfill-php81 -d typo3/sysext/core \
  --no-update

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Oliver Klee +1
    • Nikita Hovratov +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Nikita Hovratov +1
    • core-ci +1 CI

Issues 2

Files 1

Review log 79

  1. Stefan Bürk uploaded patch set 1 02/06/22, 11:22

  2. Stefan Bürk updated the commit message in patch set 2 02/06/22, 11:23

  3. Oliver Klee voted on patch set 2 CR +1 02/06/22, 11:29

  4. core-ci voted on patch set 2 V +1 02/06/22, 11:35 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/23091

  5. core-ci voted on patch set 1 V +1 02/06/22, 11:38 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/23090

  6. Stefan Bürk commented on patch set 2 02/06/22, 14:48

    Note: A "wip" patch is prepared which will help us detect such misses in the future: > 73315: [WIP][TASK] Tighten composer integration validation script | https://review.typo3.org/c/Packages/TYPO3.CMS/+/73315 Currently failing (correctly) because this patch is not merged yet. Afte this patch is merged, we can rebase that patch and it must be green. Thus merged afterwards.
  7. Nikita Hovratov voted on patch set 2 V +1 CR +1 02/06/22, 15:33

  8. Christian Kuhn voted on patch set 2 V +2 CR +2 02/07/22, 08:16

  9. Christian Kuhn merged patch set 3 02/07/22, 08:16