73315[TASK] Tighten composer integration validation script
Commit message
Review
-
Code review CR +2 Done
- Benni Mack +2
- Christian Kuhn +1
-
Verified V +2 Done
- Benni Mack +2
- Christian Kuhn +1
- core-ci +1 CI
Issues 3
Files 1
Review log 1926
Show 1 earlier messages
-
Stefan Bürk uploaded patch set 1 02/06/22, 11:46
-
Stefan Bürk commented on patch set 1 CR -1 02/06/22, 11:49
fail is extended, if checkComposer fails. Reason is that with #96749 it was missed to remove requires from sysext composer file, which this patch adds as validation. After #96756 gets merged, this patch should be rebased and than be green. Thus -1 for now. -
core-ci voted on patch set 1 V -1 02/06/22, 11:54 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/23093
-
Stefan Bürk commented on patch set 1 02/06/22, 11:55
Reply
expected output: ``` +-----------+---------+------------------------+-----------+-------------+ | EXT | type | Dependency | should be | actually is | +-----------+---------+------------------------+-----------+-------------+ | repo-root | require | symfony/polyfill-php80 | ^1.23.1 | missing | | repo-root | require | symfony/polyfill-php81 | ^1.23 | missing | +-----------+---------+------------------------+-----------+-------------+ ``` -
Stefan Bürk uploaded patch set 2 02/06/22, 11:56
-
Stefan Bürk voted on patch set 2 CR -1 02/06/22, 11:56
-
core-ci voted on patch set 2 V -1 02/06/22, 12:04 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/23094
-
Stefan Bürk uploaded patch set 3 02/06/22, 12:05
-
Stefan Bürk commented on patch set 3 CR -1 02/06/22, 12:08
Reply
Changed output, so output is expected to be: ``` +-----------+---------+--------------------------------+-----------+-------------+ | EXT | type | Dependency | should be | actually is | +-----------+---------+--------------------------------+-----------+-------------+ | repo-root | require | symfony/polyfill-php80 by core | ^1.23.1 | missing | | repo-root | require | symfony/polyfill-php81 by core | ^1.23 | missing | +-----------+---------+--------------------------------+-----------+-------------+ ``` -
core-ci voted on patch set 3 V -1 02/06/22, 12:14 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/23095
-
Stefan Bürk rebased onto patch set 4 02/07/22, 08:17
-
Stefan Bürk voted on patch set 4 CR -1 02/07/22, 08:17
-
core-ci voted on patch set 4 V +1 02/07/22, 08:26 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/23119
-
Stefan Bürk updated the commit message in patch set 5 02/07/22, 08:31
-
Stefan Bürk commented on patch set 5 02/07/22, 08:32
Reply
Related #96756 has been merged and rebase was green, like expected. Thus unwipped patch now. -
core-ci voted on patch set 5 V +1 02/07/22, 08:45 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/23122
-
Christian Kuhn uploaded patch set 6 02/07/22, 09:16
-
Christian Kuhn voted on patch set 6 V +1 CR +1 02/07/22, 09:17
-
core-ci voted on patch set 6 V +1 02/07/22, 09:25 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/23126
-
Benni Mack updated the commit message in patch set 7 02/07/22, 09:28
-
Benni Mack voted on patch set 7 V +1 CR +1 02/07/22, 09:29
-
Christian Kuhn voted on patch set 7 V +1 CR +1 02/07/22, 09:29
-
core-ci voted on patch set 7 V +1 02/07/22, 09:39 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/23127
-
Benni Mack voted on patch set 7 V +2 CR +2 02/07/22, 09:40
-
Benni Mack merged patch set 8 02/07/22, 09:40
-
Christian Kuhn voted on patch set 7 V +2 CR +2 02/07/22, 09:40