Review main Merged

73315[TASK] Tighten composer integration validation script

Stefan Bürk CR +2 V +2 Easy +11 −0 updated 02/14/22, 14:43

Commit message

The script "Build/Scripts/checkIntegrityComposer.php"
verifies composer.json dependencies of each system
extension to have the same version as the root composer.json
manifest file.

The patch adds an additional check that all dependencies
of a system extension also have a counterpart
in the main root composer.json of the development collection.

This way, we avoid scenarios where we remove a dependency from
the root composer.json and forget to remove it from system
extensions, too.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Christian Kuhn +1
  • Verified V +2 Done
    • Benni Mack +2
    • Christian Kuhn +1
    • core-ci +1 CI

Issues 3

Files 1

Review log 1926

Show 1 earlier messages
  1. Stefan Bürk uploaded patch set 1 02/06/22, 11:46

  1. Stefan Bürk commented on patch set 1 CR -1 02/06/22, 11:49

    fail is extended, if checkComposer fails. Reason is that with #96749 it was missed to remove requires from sysext composer file, which this patch adds as validation. After #96756 gets merged, this patch should be rebased and than be green. Thus -1 for now.
  2. core-ci voted on patch set 1 V -1 02/06/22, 11:54 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/23093

  3. Stefan Bürk commented on patch set 1 02/06/22, 11:55

    Reply

    expected output: ``` +-----------+---------+------------------------+-----------+-------------+ | EXT | type | Dependency | should be | actually is | +-----------+---------+------------------------+-----------+-------------+ | repo-root | require | symfony/polyfill-php80 | ^1.23.1 | missing | | repo-root | require | symfony/polyfill-php81 | ^1.23 | missing | +-----------+---------+------------------------+-----------+-------------+ ```
  4. Stefan Bürk uploaded patch set 2 02/06/22, 11:56

  5. Stefan Bürk voted on patch set 2 CR -1 02/06/22, 11:56

  6. core-ci voted on patch set 2 V -1 02/06/22, 12:04 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/23094

  7. Stefan Bürk uploaded patch set 3 02/06/22, 12:05

  8. Stefan Bürk commented on patch set 3 CR -1 02/06/22, 12:08

    Reply

    Changed output, so output is expected to be: ``` +-----------+---------+--------------------------------+-----------+-------------+ | EXT | type | Dependency | should be | actually is | +-----------+---------+--------------------------------+-----------+-------------+ | repo-root | require | symfony/polyfill-php80 by core | ^1.23.1 | missing | | repo-root | require | symfony/polyfill-php81 by core | ^1.23 | missing | +-----------+---------+--------------------------------+-----------+-------------+ ```
  9. core-ci voted on patch set 3 V -1 02/06/22, 12:14 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/23095

  10. Stefan Bürk rebased onto patch set 4 02/07/22, 08:17

  11. Stefan Bürk voted on patch set 4 CR -1 02/07/22, 08:17

  12. core-ci voted on patch set 4 V +1 02/07/22, 08:26 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/23119

  13. Stefan Bürk updated the commit message in patch set 5 02/07/22, 08:31

  14. Stefan Bürk commented on patch set 5 02/07/22, 08:32

    Reply

    Related #96756 has been merged and rebase was green, like expected. Thus unwipped patch now.
  15. core-ci voted on patch set 5 V +1 02/07/22, 08:45 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/23122

  16. Christian Kuhn uploaded patch set 6 02/07/22, 09:16

  17. Christian Kuhn voted on patch set 6 V +1 CR +1 02/07/22, 09:17

  18. core-ci voted on patch set 6 V +1 02/07/22, 09:25 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/23126

  19. Benni Mack updated the commit message in patch set 7 02/07/22, 09:28

  20. Benni Mack voted on patch set 7 V +1 CR +1 02/07/22, 09:29

  21. Christian Kuhn voted on patch set 7 V +1 CR +1 02/07/22, 09:29

  22. core-ci voted on patch set 7 V +1 02/07/22, 09:39 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/23127

  23. Benni Mack voted on patch set 7 V +2 CR +2 02/07/22, 09:40

  24. Benni Mack merged patch set 8 02/07/22, 09:40

  25. Christian Kuhn voted on patch set 7 V +2 CR +2 02/07/22, 09:40