Review main Merged

73317[BUGFIX] Load essential JavaScript in permission edit view

Stefan Bürk CR +2 V +2 Easy +7 −0 updated 02/07/22, 08:54

Commit message

During backend view refactoring with #96605 it was overseen
that essential JavaScript on permission edit view is no longer
loaded, thus current permission not displayed.

This patch adds the needed ViewHelper statement to the edit
permission template file, like it has been done for the other
views. Permission edit now works again.

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Benni Mack +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • core-ci +1 CI

Issues 2

Files 1

Review log 45

  1. Stefan Bürk uploaded patch set 1 02/06/22, 15:32

  2. core-ci voted on patch set 1 V +1 02/06/22, 15:44 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/23103

  3. Benni Mack voted on patch set 1 CR +1 02/07/22, 07:48

  4. Christian Kuhn commented on patch set 1 V +2 CR +2 02/07/22, 08:54

    That was my fail in #96605 ... I'll take the freedom to merge this.
  5. Christian Kuhn merged patch set 2 02/07/22, 08:54