Review main Merged

73318[TASK] Deprecate CompositeExpression methods and instantiation

Stefan Bürk CR +2 V +2 Hard +317 −1 updated 04/21/22, 21:56

Commit message

doctrine/dbal has deprecated multiple methods in the
class 'CompositeExpression'. Luckily, the core
already implements a facade of this class and the
proper forward-compatible implementation has been
provided with #97081 to pave a seamless migration
path for extension developers, which have to support
multi-core versions without deprecation messages.

Core usages have been replaced with #97124.
Additionally, usages in typo3/cms-styleguide have
been properly replaced as a preparation for the
deprecation with:
https://github.com/TYPO3/styleguide/pull/303

This patch finally deprecates these methods to avoid
further usage.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Oliver Klee +1
    • Nikita Hovratov +1
  • Verified V +2 Done
    • Benni Mack +2
    • Nikita Hovratov +1
    • core-ci +1 CI

Issues 3

Files 4

Review log 5583

Show 3658 earlier messages
  1. Stefan Bürk uploaded patch set 1 02/06/22, 17:35

  2. Oliver Klee commented on patch set 1 02/06/22, 17:39

    CompositeExpression.php:31

    We can add the native array type declaration here, I think.
  3. Stefan Bürk commented on patch set 1 02/06/22, 17:42

    CompositeExpression.php:31 Reply

    Ack. Will repush shortly. Man, you are fast - anyway first push was just to save work and have some general discussion - but yeah, you are right on this.
  4. Stefan Bürk uploaded patch set 2 02/06/22, 17:42

  5. Stefan Bürk commented on patch set 2 02/06/22, 17:43

    CompositeExpression.php:31 Reply

    Done
  6. core-ci voted on patch set 1 V +1 02/06/22, 17:47 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/23105

  7. core-ci voted on patch set 2 V +1 02/06/22, 17:53 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/23106

  8. Oliver Klee wrote 02/06/22, 18:45

    Removed cc Oliver Klee.
  9. Stefan Bürk uploaded patch set 3 02/08/22, 19:54

  10. core-ci voted on patch set 3 V -1 02/08/22, 20:08 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/23238

  11. Stefan Bürk uploaded patch set 4 02/08/22, 20:55

  12. core-ci voted on patch set 4 V +1 02/08/22, 21:06 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/23239

  13. Stefan Bürk rebased onto patch set 5 03/01/22, 19:51

  14. core-ci voted on patch set 5 V +1 03/01/22, 20:00 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/24418

  15. Stefan Bürk uploaded patch set 6 03/02/22, 00:19

  16. Stefan Bürk commented on patch set 6 CR -1 03/02/22, 00:22

    note (thus -1): commit message is a little bit early, so not "correct" currently. Decided to split out two pre-patches (which I will do the next days). 1. to provide new methods as "forward compatible" change with backport to v11 2. replace core usage of old methods with new ones and than finalize this deprecation patch.
  17. Stefan Bürk wrote 03/02/22, 00:41

    Topic set to doctrine/dbal
  18. core-ci voted on patch set 6 V -1 03/02/22, 01:19 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/24431

  19. Stefan Bürk uploaded patch set 7 03/05/22, 00:17

  20. Stefan Bürk updated the commit message in patch set 8 03/05/22, 00:20

  21. Stefan Bürk uploaded patch set 9 03/05/22, 00:27

  22. core-ci voted on patch set 7 V -1 03/05/22, 00:27 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/24599

  23. core-ci voted on patch set 9 V -1 03/05/22, 01:27 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/24601

  24. Stefan Bürk uploaded patch set 10 03/06/22, 15:47

  25. Stefan Bürk updated the commit message in patch set 11 03/06/22, 15:52

  26. Stefan Bürk uploaded patch set 12 03/06/22, 17:18

  27. Stefan Bürk updated the commit message in patch set 13 03/06/22, 17:22

  28. core-ci voted on patch set 13 V -1 03/06/22, 17:31 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/24644

  29. core-ci voted on patch set 12 V -1 03/06/22, 17:34 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/24643

  30. Stefan Bürk uploaded patch set 14 03/07/22, 23:39

  31. core-ci voted on patch set 14 V +1 03/07/22, 23:50 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/24700

  32. Stefan Bürk uploaded patch set 15 03/27/22, 12:24

  33. core-ci voted on patch set 15 V +1 03/27/22, 12:51 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/25186

  34. Oliver Klee commented on patch set 15 03/27/22, 15:02

    typo: mutliple -> multiple
  35. Stefan Bürk updated the commit message in patch set 16 03/27/22, 15:21

  36. Stefan Bürk commented on patch set 16 03/27/22, 15:22

    Reply

    Done
  37. core-ci voted on patch set 16 V +1 03/27/22, 15:30 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/25187

  38. Oliver Klee wrote 03/27/22, 16:31

    Removed cc Oliver Klee.
  39. Stefan Bürk rebased onto patch set 17 03/28/22, 19:00

  40. core-ci voted on patch set 17 V -1 03/28/22, 19:13 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/25226

  41. Stefan Bürk updated the commit message in patch set 18 03/28/22, 19:47

  42. core-ci voted on patch set 18 V +1 03/28/22, 20:13 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/25230

  43. Stefan Bürk updated the commit message in patch set 19 03/29/22, 19:49

  44. Stefan Bürk updated the commit message in patch set 20 03/29/22, 19:54

  45. core-ci voted on patch set 19 V +1 03/29/22, 20:03 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/25267

  46. core-ci voted on patch set 20 V +1 03/29/22, 20:05 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/25268

  47. Stefan Bürk updated the commit message in patch set 21 03/29/22, 20:27

  48. core-ci voted on patch set 21 V +1 03/29/22, 20:39 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/25270

  49. Stefan Bürk uploaded patch set 22 04/10/22, 01:20

  50. core-ci voted on patch set 22 V -1 04/10/22, 01:35 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/25893

  51. core-ci commented on patch set 22 04/10/22, 01:42 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/25893

  52. Stefan Bürk uploaded patch set 23 04/10/22, 01:46

  53. core-ci voted on patch set 23 V +1 04/10/22, 01:57 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/25894

  54. Nikita Hovratov uploaded patch set 24 04/10/22, 08:05

  55. core-ci voted on patch set 24 V +1 04/10/22, 08:19 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/25899

  56. Nikita Hovratov commented on patch set 24 04/11/22, 15:02

    CompositeExpression.php:41

    Should we change this to @deprecated? A bit easier to grep later.
  57. Stefan Bürk commented on patch set 24 04/11/22, 15:07

    CompositeExpression.php:41 Reply

    Guess this would be okay. Will check and change it later. Thanks for pointing out.
  58. Stefan Bürk uploaded patch set 25 04/11/22, 21:08

  1. Stefan Bürk commented on patch set 25 04/11/22, 21:10

    CompositeExpression.php:41 Reply

    Done. Selected this message to make it clear when display in PHPStorm popup, eg. wen hovering over (new CompositeExpression(...))
  2. core-ci voted on patch set 25 V +1 04/11/22, 21:19 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/25937

  3. Oliver Klee voted on patch set 25 CR +1 04/12/22, 19:06

  4. Stefan Bürk uploaded patch set 26 04/13/22, 10:25

  5. core-ci voted on patch set 26 V +1 04/13/22, 10:39 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/25974

  6. Oliver Klee voted on patch set 26 CR +1 04/13/22, 10:45

  7. Benni Mack voted on patch set 26 CR +1 04/14/22, 20:30

  8. Benni Mack commented on patch set 26 CR 0 04/17/22, 10:38

    MethodCallMatcher.php:27

    something is off here...
  9. Stefan Bürk uploaded patch set 27 04/17/22, 13:09

  10. Stefan Bürk commented on patch set 27 04/17/22, 13:10

    MethodCallMatcher.php:27 Reply

    Weired. Done.
  11. Oliver Klee voted on patch set 27 CR +1 04/17/22, 13:15

  12. core-ci voted on patch set 27 V +1 04/17/22, 13:21 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/26106

  13. Stefan Bürk rebased onto patch set 28 04/20/22, 00:53

  14. core-ci voted on patch set 28 V +1 04/20/22, 01:07 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/26211

  15. Nikita Hovratov uploaded patch set 29 04/21/22, 18:45

  16. Nikita Hovratov commented on patch set 29 04/21/22, 18:56

    Adjusted documentation and replaced DEBUG_BACKTRACE_PROVIDE_OBJECT with DEBUG_BACKTRACE_IGNORE_ARGS for less memory consumption. One note before I would vote: The method `add` in the MethodCallMatcher is so common, that we would have a ton of weak matches. For example QueryBuilder->add will trigger weak matches. Found it while scanning the styleguide extension. Should we remove it for cleaner scanner results?
  17. Oliver Klee voted on patch set 29 CR +1 04/21/22, 18:57

  18. Stefan Bürk commented on patch set 29 04/21/22, 18:59

    Reply

    Mhh. Ack. Needs change in ReST than too to state that only addMultiple() is scanned as weak. And thanks for the adjustments.
  19. core-ci voted on patch set 29 V +1 04/21/22, 19:00 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/26283

  20. Nikita Hovratov uploaded patch set 30 04/21/22, 19:04

  21. Nikita Hovratov voted on patch set 30 V +1 CR +1 04/21/22, 19:04

  22. Oliver Klee voted on patch set 30 CR +1 04/21/22, 19:05

  23. core-ci voted on patch set 30 V +1 04/21/22, 19:16 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/26284

  24. Benni Mack voted on patch set 30 V +2 CR +2 04/21/22, 21:56

  25. Benni Mack merged patch set 31 04/21/22, 21:56