73323[TASK] Streamline LinkBrowser controller
Commit message
Review
-
Code review CR +2 Done
- Christian Kuhn +2
- Stefan Bürk +1
-
Verified V +2 Done
- Christian Kuhn +2
- Stefan Bürk +1
- core-ci +1 CI
Issues 1
Files 4
Review log 2027
Show 12 earlier messages
-
Nikita Hovratov uploaded patch set 1 02/06/22, 20:41
-
core-ci voted on patch set 1 V -1 02/06/22, 20:54 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/23112
-
Nikita Hovratov uploaded patch set 2 02/06/22, 21:21
-
core-ci voted on patch set 2 V +1 02/06/22, 21:32 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/23113
-
Stefan Bürk commented on patch set 2 02/06/22, 23:43
-
Nikita Hovratov commented on patch set 2 02/07/22, 08:24
BrowseLinksController.php:280ReplyPrimarily this is there to avoid duplicate comments/annotations, which phpstan also can understand. I'm not sure, if this works without it. Honestly, not 100% sure if this is the way to go so I bow to superiour opinions :) -
Stefan Bürk commented on patch set 2 02/07/22, 08:56
BrowseLinksController.php:280ReplyYeah, I'm not 100% sure either. Do not know if core-team/core-merge already discussed this and has a decision on that. Personally I would tend to either remove it or keep it and avoid @inheritDoc (as this is a wildy differently used and implemented old phpDocumenter flag). @inheritDoc is nearly useless for humans (at this place), and as far as I know (not sure) is that phpstan already takes the parent into account (which could be tested). Maybe we should wait here for someone who has a deeper knowlage/decision about this. However, thanks for your answer. -
Christian Kuhn commented on patch set 2 02/07/22, 09:23
BrowseLinksController.php:280ReplyIIRC, Alex Schnitzler argued in a similar way a while ago: @inheritdoc is pretty much useless for humans, and analyzers should look at parent automatically. I tend to agree to that and would say we should simply remove the annotation here, and maybe even have a cleanup patch for those couple of places in the core where we use it. we could then even forbid the annotation in our annotation check script. -
Nikita Hovratov uploaded patch set 3 02/07/22, 10:11
-
Nikita Hovratov commented on patch set 3 02/07/22, 10:14
Removed now the inheritDoc annotations and copied them over from the abstract class. Also reordered now the methods: 1. abstract, 2. public, 3. protected.BrowseLinksController.php:280ReplyDone -
core-ci voted on patch set 3 V +1 02/07/22, 10:21 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/23129
-
Oliver Klee commented on patch set 3 02/07/22, 10:44
BrowseLinksController.php:41Please let's keep this comment even if we drop the PHPDoc type annotation. It explains things that are not conveyed by the name only. -
Nikita Hovratov uploaded patch set 4 02/07/22, 11:04
-
Nikita Hovratov commented on patch set 4 02/07/22, 11:04
BrowseLinksController.php:41ReplyDone -
core-ci voted on patch set 4 V +1 02/07/22, 11:13 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/23131
-
Oliver Klee wrote 02/07/22, 13:18
Removed cc Oliver Klee. -
Christian Kuhn commented on patch set 4 02/07/22, 13:53
Services.yaml:20let's please avoid this for now and stick to the casual getLanguageService() methods for now: the globals-lang stuff needs a major overhaul anyways and i would prefer to not clutter this single solution in there right now. is that ok with you? -
Nikita Hovratov uploaded patch set 5 02/07/22, 15:20
-
Nikita Hovratov commented on patch set 5 02/07/22, 15:23
It's ok! Changed it back to how it was originally.Services.yaml:20ReplyDone -
core-ci voted on patch set 5 V +1 02/07/22, 15:29 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/23149
-
Christian Kuhn uploaded patch set 6 02/07/22, 21:32
-
Christian Kuhn uploaded patch set 7 02/07/22, 21:36
-
core-ci voted on patch set 6 V +1 02/07/22, 21:43 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/23170
-
core-ci voted on patch set 7 V +1 02/07/22, 21:54 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/23173
-
Stefan Bürk voted on patch set 7 V +1 CR +1 02/07/22, 21:57
-
Christian Kuhn voted on patch set 7 V +2 CR +2 02/07/22, 22:00
-
Christian Kuhn merged patch set 8 02/07/22, 22:00
BrowseLinksController.php:280