Review 11.5 Merged

73328[BUGFIX] Fix undefined key warning in cObj->imageLinkWrap

Christian Kuhn CR +2 V +2 Normal +227 −10 updated 02/07/22, 09:04

Commit message

The default configuration for JSWindow in
lib.contentElement doesn't contain the params
property, so after stdWrapping it in
ContentObjectRenderer, it becomes an empty string.

Thus, exploding it needs a fallback to prevent
PHP 8.0 undefined array key warnings.

In addition, first tests have been added for
cObj->imageLinkWrap, which cover this warning. These
tests have also found another warning for
JSwindow.altUrl_noDefaultParams, which is also
fixed now.

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
  • Verified V +2 Done
    • Christian Kuhn +2
    • core-ci +1 CI

Issues 2

Files 4

Review log 34

  1. Christian Kuhn uploaded patch set 1 02/07/22, 08:44

  2. core-ci voted on patch set 1 V +1 02/07/22, 08:58 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/23124

  3. Christian Kuhn voted on patch set 1 V +2 CR +2 02/07/22, 09:04

  4. Christian Kuhn merged patch set 2 02/07/22, 09:04