Review main Merged

73330[TASK] Streamline ElementInformationController

Christian Kuhn CR +2 V +2 Hard +219 −321 updated 02/07/22, 15:08

Commit message

Basic refactoring of ElementInformationController (the
"info" modal on records). The entry method is more
clean, the class uses a bit less state, new backend
templating strategy is used. The controller is still
a bit messy and could be further cleaned up with an
additional patch that should further separate 'db',
'file' and 'folder' handling.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Stefan Bürk +1
  • Verified V +2 Done
    • Benni Mack +2
    • Stefan Bürk +1
    • core-ci +1 CI

Issues 2

Files 3

Review log 1015

  1. Christian Kuhn uploaded patch set 1 02/07/22, 12:39

  2. core-ci voted on patch set 1 V +1 02/07/22, 12:48 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/23132

  3. Christian Kuhn uploaded patch set 2 02/07/22, 13:57

  4. Christian Kuhn uploaded patch set 3 02/07/22, 13:59

  5. Stefan Bürk commented on patch set 3 CR -1 02/07/22, 14:07

    In FileList module there's a bug now. After "display info" on an image, I opend info of several folders and it always showed the file information of the recently display filed, not the folder.
  6. core-ci voted on patch set 2 V +1 02/07/22, 14:10 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/23143

  7. core-ci voted on patch set 3 V +1 02/07/22, 14:13 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/23144

  8. Christian Kuhn uploaded patch set 4 02/07/22, 14:13

  9. Christian Kuhn commented on patch set 3 02/07/22, 14:14

    Reply

    done
  10. core-ci voted on patch set 4 V -1 02/07/22, 14:25 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/23145

  11. Christian Kuhn uploaded patch set 5 02/07/22, 14:28

  12. Stefan Bürk commented on patch set 5 V +1 CR +1 02/07/22, 14:31

    Reply

    ack.
  13. core-ci voted on patch set 5 V +1 02/07/22, 14:39 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/23147

  14. Benni Mack voted on patch set 5 V +2 CR +2 02/07/22, 15:08

  15. Benni Mack merged patch set 6 02/07/22, 15:08