Review main Merged

73333[TASK] Consistently use PreviewUriBuilder

Benni Mack CR +2 V +2 Easy +20 −27 updated 02/09/22, 10:13

Commit message

This change uses the fluent API for generating
preview URLs. This way, we can replace
BackendUtility::getPreviewUri() in a next
step.

Review

  • Code review CR +2 Done
    • Georg Ringer +2
    • Jochen Roth +1
  • Verified V +2 Done
    • Georg Ringer +2
    • Jochen Roth +1
    • core-ci +1 CI

Issues 1

Files 4

Review log 710

  1. Benni Mack uploaded patch set 1 02/07/22, 13:36

  2. core-ci voted on patch set 1 V +1 02/07/22, 13:50 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/23138

  3. Benni Mack updated the commit message in patch set 2 02/08/22, 06:25

  4. core-ci voted on patch set 2 V +1 02/08/22, 06:37 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/23187

  5. Benni Mack uploaded patch set 3 02/09/22, 08:36

  6. Jochen Roth voted on patch set 3 V +1 CR +1 02/09/22, 08:42

  7. core-ci voted on patch set 3 V +1 02/09/22, 08:46 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/23257

  8. Georg Ringer voted on patch set 3 V +2 CR +2 02/09/22, 10:05

  9. Georg Ringer merged patch set 4 02/09/22, 10:05

  10. Oli Bartsch commented on patch set 4 02/09/22, 10:13

    Should use the factory method. Will push a follow up.