73337[DOCS] Mention "PackageArtifact.php" in Changelog entry
Commit message
Review
-
Code review CR +2 Done
- Lina Wolf +2
- Georg Ringer +1
- Mathias Brodala +1
-
Verified V +2 Done
- Lina Wolf +2
- Georg Ringer +1
- Mathias Brodala +1
- core-ci +1 CI
Issues 1
Files 1
Review log 1721
-
Lina Wolf uploaded patch set 1 02/07/22, 16:45
-
Mathias Brodala commented on patch set 1 CR -1 02/07/22, 16:49
Feature-94996-ConsiderAllComposerInstalledExtensionsAsActive.rst:20the artifact is located atFeature-94996-ConsiderAllComposerInstalledExtensionsAsActive.rst:21will beFeature-94996-ConsiderAllComposerInstalledExtensionsAsActive.rst:22a TYPO3v11 sprintFeature-94996-ConsiderAllComposerInstalledExtensionsAsActive.rst:22together will all other Composer dependencies.Feature-94996-ConsiderAllComposerInstalledExtensionsAsActive.rst:22was located atFeature-94996-ConsiderAllComposerInstalledExtensionsAsActive.rst:23causedFeature-94996-ConsiderAllComposerInstalledExtensionsAsActive.rst:23did needFeature-94996-ConsiderAllComposerInstalledExtensionsAsActive.rst:24, which where solved by storing it -
core-ci voted on patch set 1 V +1 02/07/22, 17:01 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/23155
-
Lina Wolf uploaded patch set 2 02/07/22, 18:05
-
Lina Wolf commented on patch set 2 02/07/22, 18:07
Feature-94996-ConsiderAllComposerInstalledExtensionsAsActive.rst:20ReplyDoneFeature-94996-ConsiderAllComposerInstalledExtensionsAsActive.rst:20ReplyDoneFeature-94996-ConsiderAllComposerInstalledExtensionsAsActive.rst:21ReplyDoneFeature-94996-ConsiderAllComposerInstalledExtensionsAsActive.rst:22ReplyDoneFeature-94996-ConsiderAllComposerInstalledExtensionsAsActive.rst:22ReplyDoneFeature-94996-ConsiderAllComposerInstalledExtensionsAsActive.rst:22ReplyDoneFeature-94996-ConsiderAllComposerInstalledExtensionsAsActive.rst:23ReplyDoneFeature-94996-ConsiderAllComposerInstalledExtensionsAsActive.rst:23ReplyDoneFeature-94996-ConsiderAllComposerInstalledExtensionsAsActive.rst:24ReplyDone -
core-ci voted on patch set 2 V +1 02/07/22, 18:14 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/23158
-
Nikita Hovratov commented on patch set 2 02/07/22, 18:28
Feature-94996-ConsiderAllComposerInstalledExtensionsAsActive.rst:22withFeature-94996-ConsiderAllComposerInstalledExtensionsAsActive.rst:24was solved -
Lina Wolf uploaded patch set 3 02/07/22, 19:23
-
Lina Wolf commented on patch set 3 02/07/22, 19:23
Feature-94996-ConsiderAllComposerInstalledExtensionsAsActive.rst:22ReplyDoneFeature-94996-ConsiderAllComposerInstalledExtensionsAsActive.rst:24Replysome issues [...] which were solved -
core-ci voted on patch set 3 V +1 02/07/22, 19:34 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/23162
-
Mathias Brodala commented on patch set 3 02/08/22, 07:43
Feature-94996-ConsiderAllComposerInstalledExtensionsAsActive.rst:24ReplyDone -
Mathias Brodala voted on patch set 3 CR +1 02/08/22, 07:43
-
Georg Ringer commented on patch set 3 02/09/22, 12:27
Feature-94996-ConsiderAllComposerInstalledExtensionsAsActive.rst:21shouldnt this be "must". TYPO3 itself doesn't deploy anything -
Mathias Brodala commented on patch set 3 02/09/22, 12:29
Feature-94996-ConsiderAllComposerInstalledExtensionsAsActive.rst:21ReplyYes and no. This text assumes that you deploy the "vendor" directory, otherwise you'd have a broken instance. In this case the file is deployed automatically. But yes, a simple change to "must" drops this implied workflow. (Then without "automatically") -
Georg Ringer commented on patch set 4 02/09/22, 12:35
Published edit on patch set 3. -
Georg Ringer voted on patch set 4 V +1 CR +1 02/09/22, 12:35
-
core-ci voted on patch set 4 V +1 02/09/22, 12:45 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/23282
-
Mathias Brodala commented on patch set 4 V +1 CR +1 02/10/22, 09:40
Feature-94996-ConsiderAllComposerInstalledExtensionsAsActive.rst:21ReplyDone -
Lina Wolf commented on patch set 4 V +2 CR +2 02/10/22, 09:41
has +1 vom core merger and one other -
Lina Wolf merged patch set 5 02/10/22, 09:41
-
Christian Kuhn commented on patch set 5 11/20/22, 14:30
has been back ported with https://review.typo3.org/c/Packages/TYPO3.CMS/+/73291
Feature-94996-ConsiderAllComposerInstalledExtensionsAsActive.rst:20