Review main Merged

73338[TASK] Use new templating strategy in ext:form

Christian Kuhn CR +2 V +2 Hard +226 −359 updated 02/07/22, 20:21

Commit message

We need to move the main templates around a bit
to apply new backend templating strategy to the
ext:form backend controllers.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Stefan Bürk +1
    • Nikita Hovratov +1
  • Verified V +2 Done
    • Benni Mack +2
    • Stefan Bürk +1
    • Nikita Hovratov +1
    • core-ci +1 CI

Issues 2

Files 10

Review log 78

  1. Christian Kuhn uploaded patch set 1 02/07/22, 17:34

  2. core-ci voted on patch set 1 V +1 02/07/22, 17:42 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/23156

  3. Nikita Hovratov voted on patch set 1 V +1 CR +1 02/07/22, 18:20

  4. Nikita Hovratov commented on patch set 1 02/07/22, 18:26

    I didn't know controller actions can/should be set to protected, cool.
  5. Christian Kuhn commented on patch set 1 02/07/22, 19:07

    Reply

    in extbase processRequest() is the entry method. everything else can and should be protected. i do than whenever i come alonge places that still don't follow this (but i hope i found all of them meanwhile).
  6. Benni Mack voted on patch set 1 V +2 CR +2 02/07/22, 20:13

  7. Benni Mack merged patch set 2 02/07/22, 20:13

  8. Stefan Bürk voted on patch set 2 V +1 CR +1 02/07/22, 20:21