73338[TASK] Use new templating strategy in ext:form
Commit message
Review
-
Code review CR +2 Done
- Benni Mack +2
- Stefan Bürk +1
- Nikita Hovratov +1
-
Verified V +2 Done
- Benni Mack +2
- Stefan Bürk +1
- Nikita Hovratov +1
- core-ci +1 CI
Issues 2
Files 10
- typo3/sysext/form/Classes/Controller/AbstractBackendController.php+2 −21
- typo3/sysext/form/Classes/Controller/FormEditorController.php+12 −67
- typo3/sysext/form/Classes/Controller/FormManagerController.php+27 −92
- typo3/sysext/form/Resources/Private/Backend/Layouts/FormEditor.htmldeleted+0 −27
- typo3/sysext/form/Resources/Private/Backend/Layouts/FormManager.htmldeleted+0 −5
- typo3/sysext/form/Resources/Private/Backend/Templates/FormManager/Index.htmldeleted+0 −132
- typo3/sysext/form/Resources/Private/Partials/Backend/FormManager/Pagination.htmlrenamed+0 −0
- typo3/sysext/form/Resources/Private/Templates/Backend/FormEditor/Index.htmlrenamed+41 −10
- typo3/sysext/form/Resources/Private/Templates/Backend/FormManager/Index.htmlnew+144 −0
- typo3/sysext/form/ext_localconf.php+0 −5
Review log 78
-
Christian Kuhn uploaded patch set 1 02/07/22, 17:34
-
core-ci voted on patch set 1 V +1 02/07/22, 17:42 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/23156
-
Nikita Hovratov voted on patch set 1 V +1 CR +1 02/07/22, 18:20
-
Nikita Hovratov commented on patch set 1 02/07/22, 18:26
I didn't know controller actions can/should be set to protected, cool. -
Christian Kuhn commented on patch set 1 02/07/22, 19:07
Reply
in extbase processRequest() is the entry method. everything else can and should be protected. i do than whenever i come alonge places that still don't follow this (but i hope i found all of them meanwhile). -
Benni Mack voted on patch set 1 V +2 CR +2 02/07/22, 20:13
-
Benni Mack merged patch set 2 02/07/22, 20:13
-
Stefan Bürk voted on patch set 2 V +1 CR +1 02/07/22, 20:21