Review main Merged Breaking

73339[!!!][FEATURE] New registration for 3rd-level modules

Benni Mack CR +2 V +2 Nightmare +2247 −2337 updated 03/09/22, 20:13

Commit message

Previously called "module functions", available in
the global `TBE_MODULES_EXT` array are refactored
to behave like "normal" backend modules. Therefore,
those modules are now also registered via the
Configuration/Backend/Modules.php file.

The global `TBE_MODULES_EXT` array is removed
together with the corresponding API method
ExtensionManagementUtility::insertModuleFunction().

Additionally the page TSconfig options
`mod.web_info.menu.function` and
`mod.web_ts.menu.function` are superfluous
and therefore removed.

Review

  • Code review CR +2 Done
    • Oli Bartsch +2
    • Jochen Roth +1
    • Benni Mack +1
  • Verified V +2 Done
    • Oli Bartsch +2
    • Jochen Roth +1
    • Benni Mack +1
    • core-ci +1 CI

Issues 1

Files 50

Show 30 more files

Review log 4682

Show 2857 earlier messages
  1. Benni Mack uploaded patch set 1 02/07/22, 17:50

  2. core-ci voted on patch set 1 V -1 02/07/22, 18:00 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/23157

  3. Benni Mack uploaded patch set 2 02/07/22, 21:09

  4. core-ci voted on patch set 2 V -1 02/07/22, 21:21 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/23168

  5. Benni Mack uploaded patch set 3 02/07/22, 21:46

  6. core-ci voted on patch set 3 V -1 02/07/22, 21:57 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/23174

  7. Benni Mack uploaded patch set 4 02/07/22, 22:00

  8. Benni Mack rebased onto patch set 5 02/07/22, 22:13

  9. core-ci voted on patch set 4 V -1 02/07/22, 22:13 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/23175

  10. core-ci voted on patch set 5 V -1 02/07/22, 22:25 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/23176

  11. Oli Bartsch uploaded patch set 6 02/07/22, 23:22

  12. core-ci voted on patch set 6 V -1 02/07/22, 23:33 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/23179

  13. Benni Mack uploaded patch set 7 02/08/22, 09:09

  14. Benni Mack uploaded patch set 8 02/08/22, 09:17

  15. core-ci voted on patch set 7 V -1 02/08/22, 09:24 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/23198

  16. core-ci voted on patch set 8 V -1 02/08/22, 09:32 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/23199

  17. Benni Mack uploaded patch set 9 02/08/22, 13:27

  18. Benni Mack uploaded patch set 10 02/08/22, 13:29

  19. Benni Mack uploaded patch set 11 02/08/22, 13:36

  20. core-ci voted on patch set 9 V -1 02/08/22, 13:47 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/23211

  21. core-ci voted on patch set 10 V -1 02/08/22, 13:50 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/23212

  22. core-ci voted on patch set 11 V -1 02/08/22, 13:52 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/23214

  23. Benni Mack uploaded patch set 12 02/09/22, 11:09

  24. core-ci voted on patch set 12 V -1 02/09/22, 11:24 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/23277

  25. Oli Bartsch uploaded patch set 13 02/09/22, 20:29

  26. core-ci voted on patch set 13 V -1 02/09/22, 20:43 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/23301

  27. Benni Mack uploaded patch set 14 02/10/22, 16:36

  28. core-ci voted on patch set 14 V -1 02/10/22, 16:56 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/23338

  29. Benni Mack uploaded patch set 15 02/11/22, 11:46

  30. core-ci voted on patch set 15 V -1 02/11/22, 12:06 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/23381

  31. Benni Mack uploaded patch set 16 02/15/22, 22:23

  32. Benni Mack uploaded patch set 17 02/15/22, 22:25

  33. Benni Mack uploaded patch set 18 02/15/22, 22:28

  34. core-ci voted on patch set 16 V -1 02/15/22, 22:39 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/23674

  35. core-ci voted on patch set 17 V -1 02/15/22, 22:44 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/23675

  36. core-ci voted on patch set 18 V -1 02/15/22, 22:46 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/23676

  37. Benni Mack uploaded patch set 19 02/16/22, 15:53

  38. core-ci voted on patch set 19 V -1 02/16/22, 16:06 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/23733

  39. Benni Mack uploaded patch set 20 02/22/22, 22:07

  40. core-ci voted on patch set 20 V -1 02/22/22, 22:20 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/24067

  41. Benni Mack uploaded patch set 21 02/22/22, 22:21

  42. core-ci voted on patch set 21 V -1 02/22/22, 22:40 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/24068

  43. Benni Mack uploaded patch set 22 02/23/22, 08:10

  44. core-ci voted on patch set 22 V -1 02/23/22, 08:25 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/24078

  45. Oli Bartsch uploaded patch set 23 02/23/22, 12:46

  46. core-ci voted on patch set 23 V -1 02/23/22, 12:59 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/24101

  47. Oli Bartsch uploaded patch set 24 02/23/22, 20:30

  48. core-ci voted on patch set 24 V -1 02/23/22, 20:43 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/24147

  49. Benni Mack uploaded patch set 25 02/24/22, 08:56

  50. core-ci voted on patch set 25 V -1 02/24/22, 09:09 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/24163

  51. Oli Bartsch uploaded patch set 26 02/25/22, 23:39

  52. core-ci voted on patch set 26 V -1 02/25/22, 23:52 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/24310

  53. core-ci commented on patch set 26 02/26/22, 00:12 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/24310

  54. Oli Bartsch uploaded patch set 27 03/02/22, 21:07

  55. core-ci voted on patch set 27 V -1 03/02/22, 21:22 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/24479

  56. Oli Bartsch uploaded patch set 28 03/08/22, 10:17

  57. core-ci voted on patch set 28 V -1 03/08/22, 10:29 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/24709

  1. Oli Bartsch uploaded patch set 29 03/08/22, 23:17

  2. core-ci voted on patch set 29 V -1 03/08/22, 23:31 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/24722

  3. Oli Bartsch uploaded patch set 30 03/09/22, 09:45

  4. core-ci voted on patch set 30 V -1 03/09/22, 09:53 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/24737

  5. Oli Bartsch uploaded patch set 31 03/09/22, 10:07

  6. Benni Mack commented on patch set 31 03/09/22, 10:08

    TypoScriptObjectBrowserController.php:451

    I think sObj can go away as well?
  7. core-ci voted on patch set 31 V +1 03/09/22, 10:21 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/24738

  8. Oli Bartsch commented on patch set 31 03/09/22, 10:34

    TypoScriptObjectBrowserController.php:451 Reply

    This option IMO needs to stay, since it is used to access the "Edit object/property value" view in the object browser.
  9. Oli Bartsch uploaded patch set 32 03/09/22, 11:36

  10. Benni Mack commented on patch set 32 03/09/22, 11:43

    Modules.php:30

    must be "admin"
  11. core-ci voted on patch set 32 V +1 03/09/22, 11:52 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/24742

  12. Oli Bartsch uploaded patch set 33 03/09/22, 12:44

  13. Oli Bartsch commented on patch set 33 03/09/22, 12:44

    Modules.php:30 Reply

    Done
  14. core-ci voted on patch set 33 V +1 03/09/22, 12:55 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/24746

  15. Oli Bartsch uploaded patch set 34 03/09/22, 16:25

  16. core-ci voted on patch set 34 V -1 03/09/22, 16:33 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/24756

  17. Oli Bartsch uploaded patch set 35 03/09/22, 17:26

  18. core-ci voted on patch set 35 V +1 03/09/22, 17:38 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/24759

  19. Benni Mack commented on patch set 35 03/09/22, 18:19

    ModuleProvider.php:58

    actually this would remove the submodule from the registry...
  20. Benni Mack voted on patch set 35 CR +1 03/09/22, 18:20

  21. Benni Mack voted on patch set 35 V +1 03/09/22, 18:23

  22. Benni Mack commented on patch set 35 03/09/22, 18:31

    ModuleProvider.php:58 Reply

    should be handled separately.
  23. Jochen Roth voted on patch set 35 V +1 CR +1 03/09/22, 20:10

  24. Oli Bartsch voted on patch set 35 V +2 CR +2 03/09/22, 20:13

  25. Oli Bartsch merged patch set 36 03/09/22, 20:13