Review main Merged

73343[BUGFIX] Also consider new placeholders in WorkspaceService

Oli Bartsch CR +2 V +2 Easy +9 −6 updated 02/08/22, 08:09

Commit message

The WorkspaceService->fetchPagesWithVersionsInTable()
method is used to fetch all pages, which contain versioned
records. This is e.g. used for highlighting the page tree.

Since new records (created in a workspace) do not hold
a t3ver_oid, they were previously not considered in the
corresponding database query.

This is now fixed by also checking the t3ver_state for
the new placeholder flag.

Review

  • Code review CR +2 Done
    • Oliver Hader +2
  • Verified V +2 Done
    • Oliver Hader +2
    • core-ci +1 CI

Issues 3

Files 1

Review log 811

  1. Oli Bartsch uploaded patch set 1 02/07/22, 22:14

  2. core-ci voted on patch set 1 V +1 02/07/22, 22:25 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/23177

  3. Oli Bartsch updated the commit message in patch set 2 02/07/22, 22:27

  4. core-ci voted on patch set 2 V +1 02/07/22, 22:36 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/23178

  5. Benni Mack voted on patch set 2 V +1 CR +1 02/08/22, 06:25

  6. Oliver Hader updated the commit message in patch set 3 02/08/22, 07:53

  7. Oliver Hader voted on patch set 3 CR +1 02/08/22, 07:54

  8. Oliver Hader voted on patch set 3 V +1 02/08/22, 07:57

  9. core-ci voted on patch set 3 V +1 02/08/22, 08:06 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/23190

  10. Oliver Hader voted on patch set 3 V +2 CR +2 02/08/22, 08:09

  11. Oliver Hader merged patch set 4 02/08/22, 08:09