Review 11.5 Merged

73344[BUGFIX] Also consider new placeholders in WorkspaceService

Oliver Hader CR +2 V +2 Easy +9 −6 updated 02/08/22, 08:14

Commit message

The WorkspaceService->fetchPagesWithVersionsInTable()
method is used to fetch all pages, which contain versioned
records. This is e.g. used for highlighting the page tree.

Since new records (created in a workspace) do not hold
a t3ver_oid, they were previously not considered in the
corresponding database query.

This is now fixed by also checking the t3ver_state for
the new placeholder flag.

Review

  • Code review CR +2 Done
    • Oliver Hader +2
  • Verified V +2 Done
    • Oliver Hader +2
    • core-ci +1 CI

Issues 3

Files 1

Review log 45

  1. Oliver Hader uploaded patch set 1 02/08/22, 07:59

  2. Oliver Hader voted on patch set 1 V +1 CR +1 02/08/22, 07:59

  3. core-ci voted on patch set 1 V +1 02/08/22, 08:11 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/23191

  4. Oliver Hader voted on patch set 1 V +2 CR +2 02/08/22, 08:14

  5. Oliver Hader merged patch set 2 02/08/22, 08:14