Review main Merged

73350[BUGFIX] Add hidden fields when opening collapsed IRRE elements

Maik Schneider CR +2 V +2 Easy +3 −1 updated 02/10/22, 23:08

Commit message

A record is rendered that has an inline record. That
record is rendered collapsed (only header rendered).
If such a child now has a renderType="hidden" field,
and the record is opened, the hidden field HTML is
missing in the ajax response.
The patch now adds the hidden field html when opening
the record via ajax (trigger renderFieldsOnly).

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Stefan Bürk +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Stefan Bürk +1
    • core-ci +1 CI

Issues 2

Files 2

Review log 812

  1. Maik Schneider uploaded patch set 1 02/08/22, 10:28

  2. core-ci voted on patch set 1 V +1 02/08/22, 10:38 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/23201

  3. Christian Kuhn uploaded patch set 2 02/10/22, 22:19

  4. Christian Kuhn updated the commit message in patch set 3 02/10/22, 22:21

  5. Christian Kuhn commented on patch set 4 02/10/22, 22:24

    Published edit on patch set 3.
  6. core-ci voted on patch set 2 V +1 02/10/22, 22:32 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/23355

  7. core-ci voted on patch set 3 V +1 02/10/22, 22:33 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/23356

  8. core-ci voted on patch set 4 V +1 02/10/22, 22:36 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/23357

  9. Stefan Bürk voted on patch set 4 V +1 CR +1 02/10/22, 22:40

  10. Christian Kuhn voted on patch set 4 V +2 CR +2 02/10/22, 23:07

  11. Christian Kuhn commented on patch set 4 02/10/22, 23:08

    thanks for this patch! hard to spot and nail area ...
  12. Christian Kuhn merged patch set 5 02/10/22, 23:08