Review main Merged

73351[BUGFIX] Fix custom FormEngineValidation registrations

Benjamin Franzke CR +2 V +2 Easy +15 −8 updated 02/10/22, 20:11

Commit message

With #96597 custom evaluations registered via
FormEngineValidation.registerCustomEvaluation()
have no longer been evaluated as a condition related
to the unrelated and no longer always defined object
TBE_EDITOR.customEvalFunctions shadowed the condition for
JavaScriptModuleInstruction-style customEvaluations.

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Stefan Bürk +1
    • Benni Mack +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Stefan Bürk +1
    • Benni Mack +1
    • core-ci +1 CI

Issues 2

Files 4

Review log 68

  1. Benjamin Franzke uploaded patch set 1 02/08/22, 11:06

  2. core-ci voted on patch set 1 V +1 02/08/22, 11:20 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/23202

  3. Benjamin Franzke updated the commit message in patch set 2 02/08/22, 11:52

  4. core-ci voted on patch set 2 V +1 02/08/22, 12:01 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/23205

  5. Benni Mack voted on patch set 2 V +1 CR +1 02/08/22, 14:53

  6. Stefan Bürk voted on patch set 2 V +1 CR +1 02/10/22, 20:10

  7. Christian Kuhn voted on patch set 2 V +2 CR +2 02/10/22, 20:11

  8. Christian Kuhn merged patch set 3 02/10/22, 20:11