Review main Merged

73354[TASK] Drop unneeded ModuleStateStorage JavaScript include

Benjamin Franzke CR +2 V +2 Easy +0 −3 updated 02/08/22, 14:49

Commit message

The ModuleStateStorage introduced in #94762
as replacement for fsMod is only used via an
<typo3-immediate-action> custom element
(provided by ModuleTemplate), but had a fallback
that requires the ModuleStateStorage to always
be loaded in the page layout.

With the removal of the fsMod shim in #96289,
the unneeded include can be removed as the
module is loaded dynamically via ImmediateActionElement.js

Review

  • Code review CR +2 Done
    • Oli Bartsch +2
    • Benni Mack +1
  • Verified V +2 Done
    • Oli Bartsch +2
    • Benni Mack +1
    • core-ci +1 CI

Issues 3

Files 2

Review log 56

  1. Benjamin Franzke uploaded patch set 1 02/08/22, 12:38

  2. Benjamin Franzke wrote 02/08/22, 12:39

    Topic set to esm
  3. core-ci voted on patch set 1 V +1 02/08/22, 12:50 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/23208

  4. Benni Mack voted on patch set 1 V +1 CR +1 02/08/22, 12:53

  5. Oli Bartsch voted on patch set 1 V +2 CR +2 02/08/22, 14:49

  6. Oli Bartsch merged patch set 2 02/08/22, 14:49