Review main Merged

73358[TASK] Declare all controllers of ext:backend as strict typed

Anja Leichsenring CR +2 V +2 Easy +19 −1 updated 02/09/22, 10:30

Commit message

Set all missing files to declare(strict_types=1);

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Oliver Klee +1
    • Benni Mack +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Benni Mack +1
    • core-ci +1 CI

Issues 1

Files 9

Review log 1219

  1. Anja Leichsenring uploaded patch set 1 02/08/22, 18:00

  2. core-ci voted on patch set 1 V -1 02/08/22, 18:19 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/23219

  3. core-ci commented on patch set 1 02/08/22, 18:30 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/23219

  4. Anja Leichsenring rebased onto patch set 2 02/08/22, 18:54

  5. Anja Leichsenring uploaded patch set 3 02/08/22, 18:56

  6. core-ci voted on patch set 2 V -1 02/08/22, 19:11 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/23225

  7. core-ci voted on patch set 3 V -1 02/08/22, 19:12 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/23226

  8. Anja Leichsenring uploaded patch set 4 02/08/22, 19:21

  9. Anja Leichsenring uploaded patch set 5 02/08/22, 19:23

  10. Oliver Klee commented on patch set 5 02/08/22, 19:34

    BackendController.php:323

    I'd like to propose to make this check both more explicit as well as more strict: if (is_string($startModule) && …)
  11. core-ci voted on patch set 4 V +1 02/08/22, 19:35 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/23229

  12. Anja Leichsenring uploaded patch set 6 02/08/22, 19:39

  13. Anja Leichsenring commented on patch set 6 02/08/22, 19:40

    BackendController.php:323 Reply

    Ack
  14. core-ci voted on patch set 5 V +1 02/08/22, 19:45 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/23230

  15. Oliver Klee voted on patch set 6 CR +1 02/08/22, 19:56

  16. core-ci voted on patch set 6 V +1 02/08/22, 20:02 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/23236

  17. Benni Mack voted on patch set 6 V +1 CR +1 02/09/22, 08:26

  18. Christian Kuhn voted on patch set 6 V +2 CR +2 02/09/22, 10:30

  19. Christian Kuhn merged patch set 7 02/09/22, 10:30