Review main Merged

73359[TASK] Declare all controllers of ext:belog as strict typed

Anja Leichsenring CR +2 V +2 Easy +2 −0 updated 02/09/22, 10:07

Commit message

Set all missing files to declare(strict_types=1);

Review

  • Code review CR +2 Done
    • Georg Ringer +2
    • Oliver Klee +1
    • Benni Mack +1
  • Verified V +2 Done
    • Georg Ringer +2
    • Benni Mack +1
    • core-ci +1 CI

Issues 1

Files 1

Review log 68

  1. Anja Leichsenring uploaded patch set 1 02/08/22, 18:04

  2. core-ci voted on patch set 1 V -1 02/08/22, 18:18 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/23220

  3. Anja Leichsenring rebased onto patch set 2 02/08/22, 18:57

  4. core-ci voted on patch set 2 V +1 02/08/22, 19:14 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/23227

  5. Oliver Klee voted on patch set 2 CR +1 02/08/22, 19:35

  6. Benni Mack voted on patch set 2 V +1 CR +1 02/09/22, 08:26

  7. Georg Ringer voted on patch set 2 V +2 CR +2 02/09/22, 10:07

  8. Georg Ringer merged patch set 3 02/09/22, 10:07