Review main Merged

73360[TASK] Declare all controllers of ext:beuser as strict typed

Anja Leichsenring CR +2 V +2 Easy +8 −6 updated 02/09/22, 08:14

Commit message

Set all missing files to declare(strict_types=1);

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Oliver Klee +1
    • Susi Moog +1
  • Verified V +2 Done
    • Benni Mack +2
    • Susi Moog +1
    • core-ci +1 CI

Issues 1

Files 1

Review log 811

  1. Anja Leichsenring uploaded patch set 1 02/08/22, 18:07

  2. core-ci voted on patch set 1 V -1 02/08/22, 18:18 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/23221

  3. Anja Leichsenring rebased onto patch set 2 02/08/22, 18:57

  4. core-ci voted on patch set 2 V -1 02/08/22, 19:14 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/23228

  5. Anja Leichsenring uploaded patch set 3 02/08/22, 19:25

  6. Oliver Klee voted on patch set 3 CR +1 02/08/22, 19:33

  7. core-ci voted on patch set 3 V +1 02/08/22, 19:37 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/23231

  8. Benni Mack voted on patch set 3 V +1 CR +1 02/09/22, 07:46

  9. Susi Moog voted on patch set 3 V +1 CR +1 02/09/22, 07:49

  10. Benni Mack voted on patch set 3 V +2 CR +2 02/09/22, 08:14

  11. Benni Mack merged patch set 4 02/09/22, 08:14