73361[BUGFIX] Avoid undefined array key in UserInformationService
Commit message
Review
-
Code review CR +2 Done
- Christian Kuhn +2
- Oli Bartsch +1
- Oliver Klee +1
- Oliver Hader +1
- Benni Mack +1
-
Verified V +2 Done
- Christian Kuhn +2
- Oli Bartsch +1
- Benni Mack +1
- core-ci +1 CI
Issues 1
Files 1
Review log 2936
Show 811 earlier messages
-
Anja Leichsenring uploaded patch set 1 02/08/22, 18:20
-
core-ci voted on patch set 1 V -1 02/08/22, 18:28 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/23222
-
Christian Kuhn commented on patch set 1 CR -1 02/08/22, 18:54
UserInformationService.php:220looks odd, too ;) -
Anja Leichsenring rebased onto patch set 2 02/08/22, 19:25
-
Anja Leichsenring uploaded patch set 3 02/08/22, 19:36
-
Anja Leichsenring commented on patch set 3 02/08/22, 19:37
UserInformationService.php:150ReplyDoneUserInformationService.php:220ReplyDone -
core-ci voted on patch set 2 V -1 02/08/22, 19:45 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/23232
-
core-ci voted on patch set 3 V +1 02/08/22, 19:47 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/23234
-
Oli Bartsch commented on patch set 3 02/08/22, 20:24
UserInformationService.php:150Could we use isset() here? -
Anja Leichsenring commented on patch set 3 02/09/22, 08:52
UserInformationService.php:150Replydoes it matter? -
Benni Mack commented on patch set 3 02/09/22, 10:52
UserInformationService.php:150Replyin core we try to avoid array_key_exists() in favor of isset() (unspoken law ;))
-
Anja Leichsenring commented on patch set 4 02/09/22, 11:02
Published edit on patch set 3. -
Anja Leichsenring commented on patch set 4 02/09/22, 11:02
UserInformationService.php:150Replywell, when noone speaks about it, how should I know? ;) Will adjust then. -
Anja Leichsenring commented on patch set 4 02/09/22, 11:02
UserInformationService.php:150ReplyDone -
core-ci voted on patch set 4 V +1 02/09/22, 11:13 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/23276
-
Oli Bartsch uploaded patch set 5 02/09/22, 11:30
-
Oli Bartsch voted on patch set 5 V +1 CR +1 02/09/22, 11:32
-
core-ci voted on patch set 5 V +1 02/09/22, 11:40 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/23279
-
Oliver Klee voted on patch set 5 CR +1 02/09/22, 11:50
-
Christian Kuhn commented on patch set 5 02/09/22, 12:11
UserInformationService.php:150afaik, ['ctrl']['title'] is not mandatory - at least it is not declared as mandatory in tca docs? Even though i suppose some more modules would fail if not set. we'd be on the safe side here (similar for the change below), if we simply check the full array path? -
Anja Leichsenring commented on patch set 6 02/09/22, 12:56
Published edit on patch set 5. -
Anja Leichsenring commented on patch set 6 02/09/22, 12:56
UserInformationService.php:150ReplyDone -
core-ci voted on patch set 6 V +1 02/09/22, 13:04 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/23284
-
Oli Bartsch commented on patch set 6 02/09/22, 13:39
UserInformationService.php:150ReplyIf we go the extra step, we should do this at the other place, too. -
Oliver Klee voted on patch set 6 CR +1 02/09/22, 20:06
-
Christian Kuhn commented on patch set 6 02/10/22, 12:14
UserInformationService.php:150Replytrue. -
Christian Kuhn uploaded patch set 7 02/10/22, 12:19
-
Christian Kuhn commented on patch set 7 02/10/22, 12:20
UserInformationService.php:150ReplyDone -
Christian Kuhn voted on patch set 7 V +1 CR +1 02/10/22, 12:20
-
core-ci voted on patch set 7 V +1 02/10/22, 12:29 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/23329
-
Oliver Klee voted on patch set 7 CR +1 02/10/22, 12:31
-
Benni Mack commented on patch set 7 V +1 CR +1 02/10/22, 12:31
Thank you -
Oli Bartsch voted on patch set 7 V +1 CR +1 02/10/22, 16:08
-
Oliver Hader voted on patch set 7 CR +1 02/10/22, 16:55
-
Christian Kuhn voted on patch set 7 V +2 CR +2 02/10/22, 17:02
-
Christian Kuhn merged patch set 8 02/10/22, 17:03
UserInformationService.php:150