Review main Merged

73362[BUGFIX] Wrong 'default' in match expression

Christian Kuhn CR +2 V +2 Easy +2 −2 updated 02/08/22, 18:53

Commit message

The match expression in PHP needs default as
keyword, not as string literal.

Review

  • Code review CR +2 Done
    • Anja Leichsenring +2
    • Oliver Klee +1
    • Wouter Wolters +1
    • Nikita Hovratov +1
  • Verified V +2 Done
    • Anja Leichsenring +2
    • Wouter Wolters +1
    • Nikita Hovratov +1
    • core-ci +1 CI

Issues 2

Files 1

Review log 78

  1. Christian Kuhn uploaded patch set 1 02/08/22, 18:40

  2. Anja Leichsenring voted on patch set 1 V +1 CR +1 02/08/22, 18:42

  3. core-ci voted on patch set 1 V +1 02/08/22, 18:50 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/23224

  4. Oliver Klee voted on patch set 1 CR +1 02/08/22, 18:50

  5. Nikita Hovratov voted on patch set 1 V +1 CR +1 02/08/22, 18:51

  6. Wouter Wolters voted on patch set 1 V +1 CR +1 02/08/22, 18:52

  7. Anja Leichsenring voted on patch set 1 V +2 CR +2 02/08/22, 18:53

  8. Anja Leichsenring merged patch set 2 02/08/22, 18:53