73363[BUGFIX] Consider spamProtectEmailAddresses markup in <f:link.email>
Commit message
Review
-
Code review CR +2 Done
- Benni Mack +2
- Stefan Bürk +1
- Christian Kuhn +1
-
Verified V +2 Done
- Benni Mack +2
- Stefan Bürk +1
- Christian Kuhn +1
- core-ci +1 CI
Issues 1
Files 2
Review log 1519
-
Oliver Hader uploaded patch set 1 02/08/22, 19:32
-
core-ci voted on patch set 1 V -1 02/08/22, 19:35 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/23233
-
Oliver Hader uploaded patch set 2 02/08/22, 19:40
-
Oliver Hader commented on patch set 2 CR -1 02/08/22, 19:44
Should™ work... however the chances are high to introduce new XSS vectors... → re-review tests again and think about potential other/new vulnerabilities -
core-ci voted on patch set 2 V +1 02/08/22, 19:56 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/23237
-
Oliver Hader uploaded patch set 3 02/09/22, 08:48
-
core-ci voted on patch set 3 V +1 02/09/22, 09:03 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/23261
-
Benni Mack voted on patch set 3 V +1 CR +1 02/09/22, 09:18
-
Christian Kuhn commented on patch set 3 02/10/22, 21:03
EmailViewHelperTest.php:114Quite frankly, I'm not a huge fan of this TypoScriptInstruction construct in the TF: The construct is underdocumented, complex, rather hard to understand, needs the global $_server X_TYPO3_TESTING_FRAMEWORK via InternalRequest, and runtime-hooks into the typoscript parser. All that is rather opaque. The approach for functional tests to simply write a sys_template record is 10 levels easier to understand and needs no state at all. Could we maybe just keep this as it was done in the code above and then think about the fate and possible improvements of the instruction stuff in another round (that area is on my todo-list to find an easier, better documented and less fiddly solution in TF). I'm not sure to vote -1 because of that right now since the change is legit and in the end it does not matter if we later change one occurrence more or less, so ... you decide. Just wanted to note my headaches with this general construct. -
Oliver Hader commented on patch set 3 CR -2 02/11/22, 13:30
EmailViewHelperTest.php:114ReplyQuite frankly I am a fan of using flexible `TypoScriptInstruction` in these testing scenarios - basically since they allow to adjust the behavior very flexible, without fiddling around with database records again and again. In the end I don't care - my task was to fix the bug... -
Christian Kuhn commented on patch set 3 V +1 CR +1 02/11/22, 13:36
EmailViewHelperTest.php:114ReplyOh. No pun intended at all. I like the API as well, I just don't like the implementation and would like to see if we could achieve the same in a more straight-forward way mid-term ... I'm fully aware you're just fixing the bug. And that is totally fine. I had hoped my last sentence would make that clear. I'll now vote +1 on the patch to show that I'm not blocking the fix in any way. -
Oliver Hader uploaded patch set 4 02/11/22, 13:45
-
Oliver Hader voted on patch set 4 CR 0 02/11/22, 13:45
-
Oliver Hader commented on patch set 4 02/11/22, 13:53
EmailViewHelperTest.php:114ReplyChanged it back to the previous state... as mentioned, I don't really care which API is used, as long as there are tests and corresponding misbehavior is addressed. -
core-ci voted on patch set 4 V +1 02/11/22, 13:55 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/23394
-
Christian Kuhn commented on patch set 4 V +1 CR +1 02/11/22, 14:13
EmailViewHelperTest.php:114ReplyDone -
Stefan Bürk voted on patch set 4 V +1 CR +1 02/11/22, 14:25
-
Benni Mack voted on patch set 4 V +2 CR +2 02/14/22, 09:03
-
Benni Mack merged patch set 5 02/14/22, 09:03