73366[!!!][FEATURE] Override any backend template with TsConfig
Commit message
Review
-
Code review CR +2 Done
- Benni Mack +2
- Stefan Bürk +1
-
Verified V +2 Done
- Benni Mack +2
- Stefan Bürk +1
- core-ci +1 CI
Issues 4
Files 43
- Build/phpstan/phpstan-baseline.neon+0 −5
- typo3/sysext/backend/Classes/Controller/PageLayoutController.php+272 −502
- typo3/sysext/backend/Classes/View/Drawing/BackendLayoutRenderer.php2+90 −94
- typo3/sysext/backend/Classes/View/BackendViewFactory.php+0 −2
- typo3/sysext/backend/Resources/Private/Partials/PageLayout/Grid/Column.html+1 −1
- typo3/sysext/backend/Resources/Private/Templates/PageLayout/PageModule.htmlnew+66 −0
- typo3/sysext/backend/Resources/Private/Templates/PageLayout/PageModuleNoAccess.htmlnew+21 −0
- typo3/sysext/backend/Tests/Functional/View/Drawing/BackendLayoutRendererTest.php+13 −52
- typo3/sysext/core/Documentation/Changelog/12.0/Breaking-96812-NoFrontendTypoScriptBasedTemplateOverridesInTheBackend.rst13new+253 −0
- typo3/sysext/core/Documentation/Changelog/12.0/Feature-96730-SimplifiedExtbackendModuleTemplateAPI.rst+5 −1
- typo3/sysext/core/Documentation/Changelog/12.0/Feature-96812-OverrideBackendTemplatesWithTSconfig.rstnew+129 −0
- typo3/sysext/dashboard/Classes/Controller/AbstractController.phpdeleted+0 −49
- typo3/sysext/dashboard/Classes/Controller/DashboardController.php4+44 −120
- typo3/sysext/dashboard/Classes/Controller/WidgetAjaxController.php+16 −39
- typo3/sysext/dashboard/Classes/Views/Factory.php+1 −0
- typo3/sysext/dashboard/Classes/Widgets/BarChartWidget.php+19 −41
- typo3/sysext/dashboard/Classes/Widgets/CtaWidget.php+19 −33
- typo3/sysext/dashboard/Classes/Widgets/DoughnutChartWidget.php+19 −41
- typo3/sysext/dashboard/Classes/Widgets/ListDataProviderInterface.php+1 −1
- typo3/sysext/dashboard/Classes/Widgets/ListWidget.php+19 −40
Show 23 more files
- typo3/sysext/dashboard/Classes/Widgets/NumberWithIconWidget.php+18 −34
- typo3/sysext/dashboard/Classes/Widgets/RequestAwareWidgetInterface.phpnew+31 −0
- typo3/sysext/dashboard/Classes/Widgets/RssWidget.php+20 −40
- typo3/sysext/dashboard/Classes/Widgets/T3GeneralInformationWidget.php+17 −28
- typo3/sysext/dashboard/Classes/Dashboard.php+3 −2
- typo3/sysext/dashboard/Classes/DashboardInitializationService.php+3 −3
- typo3/sysext/dashboard/Classes/WidgetRegistry.php+8 −3
- typo3/sysext/dashboard/Configuration/Backend/DashboardWidgets.yaml+4 −10
- typo3/sysext/dashboard/Documentation/Configuration/WidgetRegistration.rst+0 −3
- typo3/sysext/dashboard/Documentation/Configuration/WidgetTemplate.rst+12 −15
- typo3/sysext/dashboard/Documentation/Developer/AddingButtons.rst+3 −15
- typo3/sysext/dashboard/Documentation/Developer/GraphWidgetImplementation.rst+3 −14
- typo3/sysext/dashboard/Documentation/Developer/Interfaces.rst+11 −0
- typo3/sysext/dashboard/Documentation/Developer/WidgetImplementation.rst+38 −75
- typo3/sysext/dashboard/Documentation/Widgets/BarChartWidget.rst+0 −9
- typo3/sysext/dashboard/Documentation/Widgets/CTAButtonWidget.rst+0 −9
- typo3/sysext/dashboard/Documentation/Widgets/DoughnutChartWidget.rst+0 −9
- typo3/sysext/dashboard/Documentation/Widgets/ListWidget.rst+0 −9
- typo3/sysext/dashboard/Documentation/Widgets/NumberWithIconWidget.rst+0 −9
- typo3/sysext/dashboard/Documentation/Widgets/RssWidget.rst+0 −9
- typo3/sysext/dashboard/Documentation/Settings.cfg+3 −13
- typo3/sysext/dashboard/Resources/Private/Layouts/Module.htmlnew+65 −0
- typo3/sysext/dashboard/Resources/Private/Templates/Dashboard/Main.html+195 −161
Review log 3249
Show 1224 earlier messages
-
Christian Kuhn uploaded patch set 1 02/08/22, 21:52
-
core-ci voted on patch set 1 V -1 02/08/22, 22:02 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/23243
-
Christian Kuhn uploaded patch set 2 02/08/22, 22:16
-
core-ci voted on patch set 2 V -1 02/08/22, 22:25 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/23244
-
Christian Kuhn uploaded patch set 3 02/08/22, 22:44
-
core-ci voted on patch set 3 V +1 02/08/22, 22:53 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/23245
-
Christian Kuhn uploaded patch set 4 02/09/22, 18:14
-
core-ci voted on patch set 4 V +1 02/09/22, 18:23 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/23297
-
Christian Kuhn uploaded patch set 5 02/09/22, 19:44
-
core-ci voted on patch set 5 V -1 02/09/22, 19:46 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/23298
-
Christian Kuhn uploaded patch set 6 02/09/22, 19:46
-
core-ci voted on patch set 6 V -1 02/09/22, 19:57 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/23299
-
Christian Kuhn uploaded patch set 7 02/09/22, 20:34
-
core-ci voted on patch set 7 V -1 02/09/22, 20:36 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/23302
-
Christian Kuhn uploaded patch set 8 02/09/22, 20:41
-
core-ci voted on patch set 8 V +1 02/09/22, 20:50 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/23303
-
Christian Kuhn uploaded patch set 9 02/09/22, 23:20
-
core-ci voted on patch set 9 V +1 02/09/22, 23:30 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/23307
-
Christian Kuhn uploaded patch set 10 02/09/22, 23:37
-
core-ci voted on patch set 10 V +1 02/09/22, 23:45 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/23308
-
Christian Kuhn uploaded patch set 11 02/10/22, 10:08
-
core-ci voted on patch set 11 V +1 02/10/22, 10:18 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/23325
-
Christian Kuhn uploaded patch set 12 02/10/22, 10:56
-
core-ci voted on patch set 12 V +1 02/10/22, 11:04 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/23326
-
Christian Kuhn updated the commit message in patch set 13 02/10/22, 11:30
-
core-ci voted on patch set 13 V +1 02/10/22, 11:42 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/23328
-
Georg Ringer commented on patch set 13 02/10/22, 12:26
usefulBreaking-96812-NoFrontendTypoScriptBasedTemplateOverridesInTheBackend.rst:83can we keep the 100 just to make the migration more obvious or use the same number aboveBreaking-96812-NoFrontendTypoScriptBasedTemplateOverridesInTheBackend.rst:115so use 110 hiere -
Oli Bartsch commented on patch set 13 02/10/22, 13:19
Breaking-96812-NoFrontendTypoScriptBasedTemplateOverridesInTheBackend.rst:165This reads a bit like "should be / can be". Actually this breaks hard if not adapted: > Invalid service "dashboard.widget.t3blog": method "TYPO3\CMS\Dashboard\Widgets\RssWidget::__construct()" has no argument named "$view". Check your service definition. Even after removing the `$view` argument, I'm still not able to built the container due to following exception: > Invalid constructor argument 4 for service "dashboard.widget.t3blog": argument 3 must be defined before. Check your service definition. Note: dashboard.widget.t3blog is a custom widget which however behaves the same as e.g. the Core `dashboard.widget.t3news` widget. https://github.com/o-ba/custom_dashboard_widgets/blob/main/Configuration/Backend/Widgets/RssWidgets.yaml#L10 -
Christian Kuhn commented on patch set 13 02/10/22, 14:37
Breaking-96812-NoFrontendTypoScriptBasedTemplateOverridesInTheBackend.rst:165Replyhmm. it *should* be b/w compatible if you don't change the services.yaml and widget class itself at all. that was the case for all core widgets. -
Christian Kuhn commented on patch set 13 02/10/22, 14:39
Breaking-96812-NoFrontendTypoScriptBasedTemplateOverridesInTheBackend.rst:165ReplyIt's basically that *if* you change the .yaml file, you *must* change the widget class, too. If you keep both as is, they'll work, but raise a deprecation entry at build-time ... at least that was the goal ... that does not work with custom_dashboard_widgets? -
Oli Bartsch commented on patch set 13 02/10/22, 15:09
Breaking-96812-NoFrontendTypoScriptBasedTemplateOverridesInTheBackend.rst:165ReplyI could resolve the "Invalid constructor argument" exception However, for widgets, using a core widget classes, the `$view` argument MUST be omitted otherwise this leads to the mentioned: > Invalid service "dashboard.widget.t3blog": method "TYPO3\CMS\Dashboard\Widgets\RssWidget::__construct()" has no argument named "$view". Check your service definition. -
Oli Bartsch commented on patch set 13 02/10/22, 15:48
BackendLayoutRenderer.php:189Should we move this at the top of the class?DashboardController.php:12In the dashboard module the "Add widget" button in the top right corner, as well as in the "info" on empty dashboards is currently missing the styles. Only add it here since I didn't find the reason on the first look. -
Christian Kuhn uploaded patch set 14 02/10/22, 17:23
-
Christian Kuhn uploaded patch set 15 02/10/22, 17:25
-
Stefan Bürk commented on patch set 15 02/10/22, 17:26
Breaking-96812-NoFrontendTypoScriptBasedTemplateOverridesInTheBackend.rst:36isBreaking-96812-NoFrontendTypoScriptBasedTemplateOverridesInTheBackend.rst:44"leads to the" ? -
Christian Kuhn uploaded patch set 16 02/10/22, 17:27
-
core-ci voted on patch set 15 V -1 02/10/22, 17:36 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/23344
-
core-ci voted on patch set 16 V -1 02/10/22, 17:39 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/23345
-
core-ci voted on patch set 14 V -1 02/10/22, 17:39 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/23343
-
Christian Kuhn commented on patch set 16 CR -1 02/10/22, 17:40
working on comments. -
Christian Kuhn commented on patch set 16 02/10/22, 18:09
Reply
DoneBackendLayoutRenderer.php:189Replyyeah. at least before the protected methods. done.Breaking-96812-NoFrontendTypoScriptBasedTemplateOverridesInTheBackend.rst:36ReplyDoneBreaking-96812-NoFrontendTypoScriptBasedTemplateOverridesInTheBackend.rst:44ReplyDoneBreaking-96812-NoFrontendTypoScriptBasedTemplateOverridesInTheBackend.rst:83Replyi'll use the number above, too ... basically to train people that "timestamp now" is unique enough ;)Breaking-96812-NoFrontendTypoScriptBasedTemplateOverridesInTheBackend.rst:115ReplyDoneBreaking-96812-NoFrontendTypoScriptBasedTemplateOverridesInTheBackend.rst:165ReplyWe solved that with a more b/w compatible approach now. I'll add a sentence about that.DashboardController.php:12ReplyDone -
Stefan Bürk commented on patch set 16 02/10/22, 18:09
DashboardController.php:70This should be called after "$view = $this->modulTemplateFactory->create()". This will solve the issue Oliver noted with the missing styles on the add buttons. It seems that the difference is, that some basic css will get loaded later in the merged css instead before the needed dashboard css. So don't take this as "must" - maybe there is another way to ensure it is loaded after some basic css then. -
Christian Kuhn commented on patch set 16 02/10/22, 18:11
DashboardController.php:70Replyyeah. found same solution. will push in some minutes. -
Christian Kuhn uploaded patch set 17 02/10/22, 18:46
-
core-ci voted on patch set 17 V +1 02/10/22, 18:57 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/23348
-
Stefan Bürk voted on patch set 17 V +1 CR +1 02/10/22, 19:45
-
Benni Mack voted on patch set 17 CR +1 02/11/22, 12:57
-
Benni Mack voted on patch set 17 V +2 CR +2 02/11/22, 13:19
-
Benni Mack merged patch set 18 02/11/22, 13:19