Review main Merged

73367[TASK] Add BackendModuleValidator PSR-15 middleware

Oli Bartsch CR +2 V +2 Hard +348 −164 updated 02/09/22, 08:14

Commit message

Since introduction of the new module registration API (#96733),
the TYPO3 backend route object might contain a Module object
as "module" option.

This option was then previously used in the RouteDispatcher to
check, whether the current user has necessary access permissions
for this module.

However, the RouteDispatcher should not handle such validation
tasks, but only dispatch to the defined target.

Therefore, validation of the module access permissions, as well
as further checks (e.g. for a given page id) are now moved into
a dedicated PSR-15 middleware.

To further improve the new API, the middleware also adds the
module as attribute to the request.

Additionally, the now obsolete "moduleName" route option is
removed. It is always the same as the module identifier and
can therefore be fetched via the object.

Review

  • Code review CR +2 Done
    • Georg Ringer +2
    • Benni Mack +1
  • Verified V +2 Done
    • Georg Ringer +2
    • Benni Mack +1
    • core-ci +1 CI

Issues 2

Files 17

Review log 69

  1. Oli Bartsch uploaded patch set 1 02/08/22, 23:30

  2. core-ci voted on patch set 1 V +1 02/08/22, 23:40 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/23246

  3. Oli Bartsch uploaded patch set 2 02/08/22, 23:49

  4. Oli Bartsch updated the commit message in patch set 3 02/08/22, 23:51

  5. core-ci voted on patch set 2 V +1 02/09/22, 00:02 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/23247

  6. core-ci voted on patch set 3 V +1 02/09/22, 00:30 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/23248

  7. Benni Mack voted on patch set 3 V +1 CR +1 02/09/22, 07:58

  8. Georg Ringer voted on patch set 3 V +2 CR +2 02/09/22, 08:14

  9. Georg Ringer merged patch set 4 02/09/22, 08:14