Review main Merged

73368[BUGFIX] Prevent overwriting of view variable

Oli Bartsch CR +2 V +2 Easy +2 −2 updated 02/09/22, 09:01

Commit message

The InfoModuleController previously added the form
action url as "moduleName" to the view. Since #96730,
this variable name is overwritten by the ModuleTemplate.

Since then, instead of the form action url, the variable
only contained the module identifier. This lead to
misbehavior on submitting the form.

The form action url is therefore is now added, using
the dedicated "formAction" variable.

Review

  • Code review CR +2 Done
    • Georg Ringer +2
    • Benni Mack +1
  • Verified V +2 Done
    • Georg Ringer +2
    • Benni Mack +1
    • core-ci +1 CI

Issues 2

Files 2

Review log 56

  1. Oli Bartsch uploaded patch set 1 02/09/22, 00:12

  2. core-ci voted on patch set 1 V +1 02/09/22, 00:21 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/23249

  3. Benni Mack voted on patch set 1 V +1 CR +1 02/09/22, 07:10

  4. Georg Ringer voted on patch set 1 V +2 CR +2 02/09/22, 08:10

  5. Georg Ringer merged patch set 2 02/09/22, 08:10

  6. Christian Kuhn commented on patch set 2 02/09/22, 09:01

    oh. good catch. thx. would have voted, but wasn't quick enough.