73370[FEATURE] Provide SiteLanguageProcessor
Commit message
Review
-
Code review CR +2 Done
- Oli Bartsch +2
- Georg Ringer +1
- Benni Mack +1
-
Verified V +2 Done
- Oli Bartsch +2
- Georg Ringer +1
- Benni Mack +1
- core-ci +1 CI
Issues 1
Files 3
Review log 2331
Show 56 earlier messages
-
Georg Ringer uploaded patch set 1 02/09/22, 06:24
-
Georg Ringer commented on patch set 1 02/09/22, 06:24
This change is ready for review. -
core-ci voted on patch set 1 V -1 02/09/22, 06:34 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/23254
-
Georg Ringer uploaded patch set 2 02/09/22, 08:09
-
Benni Mack uploaded patch set 3 02/09/22, 08:14
-
Benni Mack voted on patch set 3 V +1 CR +1 02/09/22, 08:14
-
core-ci voted on patch set 3 V +1 02/09/22, 08:26 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/23256
-
Oli Bartsch commented on patch set 3 CR -1 02/09/22, 08:51
Some comments refer to the "site object". Will update. -
Oli Bartsch uploaded patch set 4 02/09/22, 09:12
-
Oli Bartsch uploaded patch set 5 02/09/22, 09:22
-
core-ci voted on patch set 4 V +1 02/09/22, 09:26 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/23263
-
Oli Bartsch commented on patch set 5 02/09/22, 09:27
SiteLanguage.php:343Do we really need this new method? We could also just use the existing `$siteLanguage->toArray()` in the data processor. This also makes custom config available. This would also have the benefit of not having duplicated (and maybe outdated - as $configuration contains all unprocessed values from the config file) information. What do you think? -
core-ci voted on patch set 5 V +1 02/09/22, 09:32 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/23265
-
Oli Bartsch uploaded patch set 6 02/09/22, 09:42
-
core-ci voted on patch set 6 V -1 02/09/22, 09:45 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/23270
-
Oli Bartsch uploaded patch set 7 02/09/22, 09:51
-
core-ci voted on patch set 7 V +1 02/09/22, 10:08 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/23271
-
Georg Ringer commented on patch set 7 02/09/22, 10:19
SiteLanguage.php:343ReplytoArray does not work in fluid as it doesnt start with "get". In my own implementations I return toArray() to the template which could also be an option -
Oli Bartsch commented on patch set 7 02/09/22, 10:25
SiteLanguage.php:343ReplyYes, that's what I mean: $processedData[$targetVariableName] = $cObj->getRequest()->getAttribute('language')?->toArray(); -
Oli Bartsch uploaded patch set 8 02/09/22, 10:58
-
Oli Bartsch voted on patch set 8 V +1 CR +1 02/09/22, 11:01
-
Oli Bartsch commented on patch set 8 02/09/22, 11:01
SiteLanguage.php:343ReplyDone -
core-ci voted on patch set 8 V +1 02/09/22, 11:09 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/23275
-
Georg Ringer voted on patch set 8 V +1 CR +1 02/09/22, 11:50
-
Oliver Klee commented on patch set 8 02/09/22, 11:51
SiteLanguageProcessorTest.php:29Nitpick: As we're not using Prophecy in this test, we don't need to import & use the trait. -
Benni Mack commented on patch set 9 02/09/22, 12:28
Published edit on patch set 8. -
Georg Ringer voted on patch set 9 V +1 CR +1 02/09/22, 12:38
-
core-ci voted on patch set 9 V +1 02/09/22, 12:44 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/23281
-
Benni Mack commented on patch set 9 V +1 CR +1 02/09/22, 12:58
SiteLanguageProcessorTest.php:29ReplyDone -
Oli Bartsch voted on patch set 9 V +2 CR +2 02/09/22, 13:08
-
Oli Bartsch merged patch set 10 02/09/22, 13:08