Review main Merged

73370[FEATURE] Provide SiteLanguageProcessor

Georg Ringer CR +2 V +2 Normal +147 −0 updated 02/09/22, 13:08

Commit message

The SiteLanguageProcessor retrieves the current siteLanguage entity as
it can be useful to have this information available in the templates.

Review

  • Code review CR +2 Done
    • Oli Bartsch +2
    • Georg Ringer +1
    • Benni Mack +1
  • Verified V +2 Done
    • Oli Bartsch +2
    • Georg Ringer +1
    • Benni Mack +1
    • core-ci +1 CI

Issues 1

Files 3

Review log 2331

Show 56 earlier messages
  1. Georg Ringer uploaded patch set 1 02/09/22, 06:24

  2. Georg Ringer commented on patch set 1 02/09/22, 06:24

    This change is ready for review.
  3. core-ci voted on patch set 1 V -1 02/09/22, 06:34 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/23254

  4. Georg Ringer uploaded patch set 2 02/09/22, 08:09

  5. Benni Mack uploaded patch set 3 02/09/22, 08:14

  6. Benni Mack voted on patch set 3 V +1 CR +1 02/09/22, 08:14

  1. core-ci voted on patch set 3 V +1 02/09/22, 08:26 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/23256

  2. Oli Bartsch commented on patch set 3 CR -1 02/09/22, 08:51

    Some comments refer to the "site object". Will update.
  3. Oli Bartsch uploaded patch set 4 02/09/22, 09:12

  4. Oli Bartsch uploaded patch set 5 02/09/22, 09:22

  5. core-ci voted on patch set 4 V +1 02/09/22, 09:26 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/23263

  6. Oli Bartsch commented on patch set 5 02/09/22, 09:27

    SiteLanguage.php:343

    Do we really need this new method? We could also just use the existing `$siteLanguage->toArray()` in the data processor. This also makes custom config available. This would also have the benefit of not having duplicated (and maybe outdated - as $configuration contains all unprocessed values from the config file) information. What do you think?
  7. core-ci voted on patch set 5 V +1 02/09/22, 09:32 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/23265

  8. Oli Bartsch uploaded patch set 6 02/09/22, 09:42

  9. core-ci voted on patch set 6 V -1 02/09/22, 09:45 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/23270

  10. Oli Bartsch uploaded patch set 7 02/09/22, 09:51

  11. core-ci voted on patch set 7 V +1 02/09/22, 10:08 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/23271

  12. Georg Ringer commented on patch set 7 02/09/22, 10:19

    SiteLanguage.php:343 Reply

    toArray does not work in fluid as it doesnt start with "get". In my own implementations I return toArray() to the template which could also be an option
  13. Oli Bartsch commented on patch set 7 02/09/22, 10:25

    SiteLanguage.php:343 Reply

    Yes, that's what I mean: $processedData[$targetVariableName] = $cObj->getRequest()->getAttribute('language')?->toArray();
  14. Oli Bartsch uploaded patch set 8 02/09/22, 10:58

  15. Oli Bartsch voted on patch set 8 V +1 CR +1 02/09/22, 11:01

  16. Oli Bartsch commented on patch set 8 02/09/22, 11:01

    SiteLanguage.php:343 Reply

    Done
  17. core-ci voted on patch set 8 V +1 02/09/22, 11:09 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/23275

  18. Georg Ringer voted on patch set 8 V +1 CR +1 02/09/22, 11:50

  19. Oliver Klee commented on patch set 8 02/09/22, 11:51

    SiteLanguageProcessorTest.php:29

    Nitpick: As we're not using Prophecy in this test, we don't need to import & use the trait.
  20. Benni Mack commented on patch set 9 02/09/22, 12:28

    Published edit on patch set 8.
  21. Georg Ringer voted on patch set 9 V +1 CR +1 02/09/22, 12:38

  22. core-ci voted on patch set 9 V +1 02/09/22, 12:44 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/23281

  23. Benni Mack commented on patch set 9 V +1 CR +1 02/09/22, 12:58

    SiteLanguageProcessorTest.php:29 Reply

    Done
  24. Oli Bartsch voted on patch set 9 V +2 CR +2 02/09/22, 13:08

  25. Oli Bartsch merged patch set 10 02/09/22, 13:08