Review main Merged

73372[TASK] Use PSR-7 Request information in cObj

Benni Mack CR +2 V +2 Easy +15 −7 updated 02/10/22, 19:51

Commit message

Since TYPO3 v11, the PSR-7 Request Object
is always available in ContentObjectRenderer,
so it can be used to access GET/POST parameters
instead of GeneralUtility::_GET() and GeneralUtility::_POST()

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Stefan Bürk +1
    • Oliver Hader +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Stefan Bürk +1
    • core-ci +1 CI

Issues 1

Files 2

Review log 912

  1. Benni Mack uploaded patch set 1 02/09/22, 08:43

  2. core-ci voted on patch set 1 V -1 02/09/22, 09:00 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/23260

  3. Benni Mack uploaded patch set 2 02/09/22, 09:27

  4. core-ci voted on patch set 2 V -1 02/09/22, 09:42 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/23266

  5. Oliver Hader commented on patch set 2 02/09/22, 11:28

    See * https://github.com/TYPO3/testing-framework/pull/327 - Testing Framework has to populate super globals again * https://review.typo3.org/c/Packages/TYPO3.CMS/+/73376 - produces the same CI failures → we just did not know about them, these flaws existed before
  6. Oliver Hader rebased onto patch set 3 02/10/22, 17:03

  7. Oliver Hader voted on patch set 3 CR +1 02/10/22, 17:19

  8. core-ci voted on patch set 3 V +1 02/10/22, 17:20 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/23342

  9. Christian Kuhn voted on patch set 3 V +1 CR +1 02/10/22, 17:42

  10. Stefan Bürk voted on patch set 3 V +1 CR +1 02/10/22, 19:48

  11. Christian Kuhn voted on patch set 3 V +2 CR +2 02/10/22, 19:51

  12. Christian Kuhn merged patch set 4 02/10/22, 19:51