Review main Merged

73373[BUGFIX] Use integer instead of strings as default for new Mail config

Benni Mack CR +2 V +2 Normal +31 −31 updated 02/09/22, 09:52

Commit message

Default values should be integer for the newly
introduced MAIL options in
https://review.typo3.org/c/Packages/TYPO3.CMS/+/69907

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Georg Ringer +1
    • Oliver Hader +1
  • Verified V +2 Done
    • Benni Mack +2
    • Georg Ringer +1
    • Oliver Hader +1
    • core-ci +1 CI

Issues 2

Files 3

Review log 1417

  1. Benni Mack uploaded patch set 1 02/09/22, 09:20

  2. Georg Ringer commented on patch set 1 02/09/22, 09:22

    but install tool configuration will be still all written as strings ....
  3. Oliver Hader voted on patch set 1 CR +1 02/09/22, 09:24

  4. Oliver Hader commented on patch set 1 02/09/22, 09:27

    DefaultConfiguration.php:1366

  5. Benni Mack commented on patch set 1 02/09/22, 09:29

    Reply

    right!
  6. Oliver Hader uploaded patch set 2 02/09/22, 09:34

  7. Oliver Hader commented on patch set 2 02/09/22, 09:35

    Reply

    Solved by updating declarations in YAML
  8. Oliver Hader voted on patch set 2 V +1 CR +1 02/09/22, 09:35

  9. core-ci voted on patch set 1 V +1 02/09/22, 09:35 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/23264

  10. Benni Mack uploaded patch set 3 02/09/22, 09:36

  11. Oliver Hader voted on patch set 3 V +1 CR +1 02/09/22, 09:41

  12. Georg Ringer voted on patch set 3 V +2 CR +2 02/09/22, 09:46

  13. core-ci voted on patch set 2 V +1 02/09/22, 09:46 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/23267

  14. Georg Ringer voted on patch set 3 V +1 CR +1 02/09/22, 09:46

  15. core-ci voted on patch set 3 V +1 02/09/22, 09:49 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/23269

  16. Benni Mack commented on patch set 3 V +2 CR +2 02/09/22, 09:52

    DefaultConfiguration.php:1366 Reply

    Done
  17. Benni Mack merged patch set 4 02/09/22, 09:52