73373[BUGFIX] Use integer instead of strings as default for new Mail config
Commit message
Review
-
Code review CR +2 Done
- Benni Mack +2
- Georg Ringer +1
- Oliver Hader +1
-
Verified V +2 Done
- Benni Mack +2
- Georg Ringer +1
- Oliver Hader +1
- core-ci +1 CI
Issues 2
Files 3
Review log 1417
-
Benni Mack uploaded patch set 1 02/09/22, 09:20
-
Georg Ringer commented on patch set 1 02/09/22, 09:22
but install tool configuration will be still all written as strings .... -
Oliver Hader voted on patch set 1 CR +1 02/09/22, 09:24
-
Oliver Hader commented on patch set 1 02/09/22, 09:27
DefaultConfiguration.php:1366Admin Tool probably would override that again with string (`text`), as declared in https://github.com/TYPO3/typo3/blob/72640460eda75ebfd7942c0e486e90ed341229e7/typo3/sysext/core/Configuration/DefaultConfigurationDescription.yaml#L607-L609 -
Benni Mack commented on patch set 1 02/09/22, 09:29
Reply
right! -
Oliver Hader uploaded patch set 2 02/09/22, 09:34
-
Oliver Hader commented on patch set 2 02/09/22, 09:35
Reply
Solved by updating declarations in YAML -
Oliver Hader voted on patch set 2 V +1 CR +1 02/09/22, 09:35
-
core-ci voted on patch set 1 V +1 02/09/22, 09:35 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/23264
-
Benni Mack uploaded patch set 3 02/09/22, 09:36
-
Oliver Hader voted on patch set 3 V +1 CR +1 02/09/22, 09:41
-
Georg Ringer voted on patch set 3 V +2 CR +2 02/09/22, 09:46
-
core-ci voted on patch set 2 V +1 02/09/22, 09:46 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/23267
-
Georg Ringer voted on patch set 3 V +1 CR +1 02/09/22, 09:46
-
core-ci voted on patch set 3 V +1 02/09/22, 09:49 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/23269
-
Benni Mack commented on patch set 3 V +2 CR +2 02/09/22, 09:52
DefaultConfiguration.php:1366ReplyDone -
Benni Mack merged patch set 4 02/09/22, 09:52