73379[!!!][TASK] Improve code of extbase based models
Commit message
Review
-
Code review CR 0
-
Verified V 0
Files 9
- typo3/sysext/belog/Classes/Domain/Model/LogEntry.php1+43 −209
- typo3/sysext/beuser/Classes/Domain/Model/BackendUser.php+46 −194
- typo3/sysext/beuser/Classes/Domain/Model/BackendUserGroup.php+12 −41
- typo3/sysext/core/Documentation/Changelog/12.0/Breaking-96817-ChangedSignatureOfExtbaseModels.rstnew+47 −0
- typo3/sysext/extbase/Classes/Domain/Model/AbstractFileFolder.php+4 −11
- typo3/sysext/extbase/Classes/Domain/Model/Category.php+11 −45
- typo3/sysext/extbase/Classes/Domain/Model/File.php+4 −4
- typo3/sysext/extbase/Classes/Domain/Model/FileReference.php+5 −10
- typo3/sysext/extensionmanager/Classes/Domain/Model/Extension.php1+69 −279
Review log 1829
Show 24 earlier messages
-
Georg Ringer uploaded patch set 1 02/09/22, 15:04
-
core-ci voted on patch set 1 V -1 02/09/22, 15:06 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/23286
-
Georg Ringer uploaded patch set 2 02/10/22, 05:36
-
core-ci voted on patch set 2 V -1 02/10/22, 05:49 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/23313
-
Georg Ringer uploaded patch set 3 02/10/22, 05:54
-
core-ci voted on patch set 3 V -1 02/10/22, 06:08 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/23314
-
Georg Ringer uploaded patch set 4 02/10/22, 07:15
-
core-ci voted on patch set 4 V -1 02/10/22, 07:28 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/23315
-
Georg Ringer uploaded patch set 5 02/10/22, 07:35
-
core-ci voted on patch set 5 V -1 02/10/22, 07:49 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/23316
-
Georg Ringer uploaded patch set 6 02/10/22, 08:05
-
core-ci voted on patch set 6 V -1 02/10/22, 08:19 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/23317
-
Georg Ringer uploaded patch set 7 02/10/22, 09:03
-
Georg Ringer uploaded patch set 8 02/10/22, 09:05
-
core-ci voted on patch set 7 V -1 02/10/22, 09:17 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/23318
-
core-ci voted on patch set 8 V +1 02/10/22, 09:18 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/23319
-
Georg Ringer uploaded patch set 9 02/14/22, 07:12
-
core-ci voted on patch set 9 V +1 02/14/22, 07:22 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/23486
-
Georg Ringer commented on patch set 9 02/14/22, 07:35
This change is ready for review. -
Georg Ringer commented on patch set 10 02/16/22, 18:44
Published edit on patch set 9. -
core-ci voted on patch set 10 V +1 02/16/22, 18:59 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/23744
-
Benni Mack uploaded patch set 11 02/16/22, 20:41
-
Georg Ringer voted on patch set 11 V +1 CR +1 02/16/22, 20:47
-
core-ci voted on patch set 11 V +1 02/16/22, 20:51 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/23748
-
Christian Kuhn commented on patch set 11 CR -1 02/16/22, 21:32
general -1: needs a good review if breaking or not. currently unsure about details, but i may be wrong. if breaking, this should have breaking.rst. -
Christian Kuhn commented on patch set 11 02/16/22, 21:34
Reply
> general -1: needs a good review if breaking or not. currently unsure about details, but i may be wrong. if breaking, this should have breaking.rst. if breaking and all is covered by breaking .rst, we should see if this is really needed. at the moment i don't really understand neither impact nor coverage nor benefit. i may be confused, though and need a bit more time on this. -
Georg Ringer commented on patch set 11 02/17/22, 07:32
Reply Unresolved
yeah sure there might be regressions deep covered somewhere because of missing type cast but this be easy to fix and also good to know. and I really don't know why the benefit of having more types is not helpful -
Oli Bartsch commented on patch set 11 02/17/22, 10:58
LogEntry.php:308Unresolvedstring|int can be defined as type hint here.Extension.php:147Unresolvedstring|int can be defined as type hint here. -
Georg Ringer abandoned the change 02/18/22, 08:58
breaking code must be avoided, abandoned