Review main Abandoned Breaking

73379[!!!][TASK] Improve code of extbase based models

Georg Ringer CR 0 V 0 Expert +241 −793 updated 02/18/22, 08:58

Commit message

Simplify and improve the code of models based on extbase by
changing:

- Add return types
- Add type declarations
- Remove not needed comments

Review

  • Code review CR 0
  • Verified V 0

Files 9

Review log 1829

Show 24 earlier messages
  1. Georg Ringer uploaded patch set 1 02/09/22, 15:04

  2. core-ci voted on patch set 1 V -1 02/09/22, 15:06 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/23286

  3. Georg Ringer uploaded patch set 2 02/10/22, 05:36

  4. core-ci voted on patch set 2 V -1 02/10/22, 05:49 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/23313

  1. Georg Ringer uploaded patch set 3 02/10/22, 05:54

  2. core-ci voted on patch set 3 V -1 02/10/22, 06:08 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/23314

  3. Georg Ringer uploaded patch set 4 02/10/22, 07:15

  4. core-ci voted on patch set 4 V -1 02/10/22, 07:28 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/23315

  5. Georg Ringer uploaded patch set 5 02/10/22, 07:35

  6. core-ci voted on patch set 5 V -1 02/10/22, 07:49 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/23316

  7. Georg Ringer uploaded patch set 6 02/10/22, 08:05

  8. core-ci voted on patch set 6 V -1 02/10/22, 08:19 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/23317

  9. Georg Ringer uploaded patch set 7 02/10/22, 09:03

  10. Georg Ringer uploaded patch set 8 02/10/22, 09:05

  11. core-ci voted on patch set 7 V -1 02/10/22, 09:17 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/23318

  12. core-ci voted on patch set 8 V +1 02/10/22, 09:18 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/23319

  13. Georg Ringer uploaded patch set 9 02/14/22, 07:12

  14. core-ci voted on patch set 9 V +1 02/14/22, 07:22 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/23486

  15. Georg Ringer commented on patch set 9 02/14/22, 07:35

    This change is ready for review.
  16. Georg Ringer commented on patch set 10 02/16/22, 18:44

    Published edit on patch set 9.
  17. core-ci voted on patch set 10 V +1 02/16/22, 18:59 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/23744

  18. Benni Mack uploaded patch set 11 02/16/22, 20:41

  19. Georg Ringer voted on patch set 11 V +1 CR +1 02/16/22, 20:47

  20. core-ci voted on patch set 11 V +1 02/16/22, 20:51 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/23748

  21. Christian Kuhn commented on patch set 11 CR -1 02/16/22, 21:32

    general -1: needs a good review if breaking or not. currently unsure about details, but i may be wrong. if breaking, this should have breaking.rst.
  22. Christian Kuhn commented on patch set 11 02/16/22, 21:34

    Reply

    > general -1: needs a good review if breaking or not. currently unsure about details, but i may be wrong. if breaking, this should have breaking.rst. if breaking and all is covered by breaking .rst, we should see if this is really needed. at the moment i don't really understand neither impact nor coverage nor benefit. i may be confused, though and need a bit more time on this.
  23. Georg Ringer commented on patch set 11 02/17/22, 07:32

    Reply Unresolved

    yeah sure there might be regressions deep covered somewhere because of missing type cast but this be easy to fix and also good to know. and I really don't know why the benefit of having more types is not helpful
  24. Oli Bartsch commented on patch set 11 02/17/22, 10:58

    LogEntry.php:308 Unresolved

    string|int can be defined as type hint here.

    Extension.php:147 Unresolved

    string|int can be defined as type hint here.
  25. Georg Ringer abandoned the change 02/18/22, 08:58

    breaking code must be avoided, abandoned