Review 11.5 Merged

73387[TASK] Streamline request handling in frontend functional tests

Oliver Hader CR +2 V +2 Easy +27 −8 updated 02/10/22, 20:07

Commit message

see https://github.com/TYPO3/testing-framework/pull/328

composer req --dev typo3/testing-framework:^6.15.3

Besides that, corresponding test cases for shortcut redirects
were extended to make the actual behavior more explicit there.

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Stefan Bürk +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Stefan Bürk +1
    • core-ci +1 CI

Issues 1

Files 4

Review log 1420

  1. Oliver Hader uploaded patch set 1 02/10/22, 14:48

  2. core-ci voted on patch set 1 V -1 02/10/22, 15:02 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/23331

  3. Oliver Hader uploaded patch set 2 02/10/22, 16:01

  4. Oliver Hader uploaded patch set 3 02/10/22, 16:01

  5. Oliver Hader uploaded patch set 4 02/10/22, 16:14

  6. core-ci voted on patch set 2 V -1 02/10/22, 16:14 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/23332

  7. core-ci voted on patch set 3 V +1 02/10/22, 16:24 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/23333

  8. core-ci voted on patch set 4 V +1 02/10/22, 16:25 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/23334

  9. Oliver Hader uploaded patch set 5 02/10/22, 16:39

  10. core-ci voted on patch set 5 V +1 02/10/22, 16:55 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/23339

  11. Oliver Hader uploaded patch set 6 02/10/22, 17:02

  12. Oliver Hader marked it ready for review 02/10/22, 17:02

  13. core-ci voted on patch set 6 V +1 02/10/22, 17:12 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/23340

  14. Oliver Hader commented on patch set 6 02/10/22, 17:21

    side-note: TYPO3 v11 only - not in `main` branch
  15. Oliver Hader commented on patch set 6 02/10/22, 17:22

    Reply

    Well... okay... tests could go to `main` as well, okay... ;)
  16. Oliver Hader commented on patch set 6 02/10/22, 17:27

  17. Christian Kuhn voted on patch set 6 V +1 CR +1 02/10/22, 17:43

  18. Stefan Bürk voted on patch set 6 V +1 CR +1 02/10/22, 18:21

  19. Christian Kuhn voted on patch set 6 V +2 CR +2 02/10/22, 20:07

  20. Christian Kuhn merged patch set 7 02/10/22, 20:07