Review main Merged

73412[TASK] Migrate FilesContentObjectTest to functional test

Nikita Hovratov CR +2 V +2 Hard +118 −338 updated 02/10/22, 20:23

Commit message

This UnitTest makes some heavy usage of mocking and
way too smart logic for a test. By migrating it to
a functional test, all this can disappear and can be
recreated with real data.

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Stefan Bürk +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Stefan Bürk +1
    • core-ci +1 CI

Issues 1

Files 15

Review log 711

  1. Nikita Hovratov uploaded patch set 1 02/10/22, 18:53

  2. Nikita Hovratov rebased onto patch set 2 02/10/22, 19:01

  3. core-ci voted on patch set 1 V -1 02/10/22, 19:01 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/23349

  4. core-ci voted on patch set 2 V -1 02/10/22, 19:10 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/23350

  5. Nikita Hovratov uploaded patch set 3 02/10/22, 19:12

  6. core-ci voted on patch set 3 V +1 02/10/22, 19:23 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/23351

  7. Nikita Hovratov uploaded patch set 4 02/10/22, 19:34

  8. core-ci voted on patch set 4 V +1 02/10/22, 19:43 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/23352

  9. Stefan Bürk voted on patch set 4 V +1 CR +1 02/10/22, 20:22

  10. Christian Kuhn commented on patch set 4 V +2 CR +2 02/10/22, 20:22

    Awesome job! Many thanks!
  11. Christian Kuhn merged patch set 5 02/10/22, 20:23