Review 11.5 Merged

73413[TASK] Migrate FilesContentObjectTest to functional test

Christian Kuhn CR +2 V +2 Hard +119 −323 updated 02/10/22, 20:36

Commit message

This UnitTest makes some heavy usage of mocking and
way too smart logic for a test. By migrating it to
a functional test, all this can disappear and can be
recreated with real data.

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Stefan Bürk +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Stefan Bürk +1
    • core-ci +1 CI

Issues 1

Files 15

Review log 45

  1. Christian Kuhn uploaded patch set 1 02/10/22, 20:22

  2. Stefan Bürk voted on patch set 1 V +1 CR +1 02/10/22, 20:28

  3. core-ci voted on patch set 1 V +1 02/10/22, 20:31 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/23353

  4. Christian Kuhn voted on patch set 1 V +2 CR +2 02/10/22, 20:35

  5. Christian Kuhn merged patch set 2 02/10/22, 20:36