Review main Merged

73415[FEATURE] Unified module data

Benni Mack CR +2 V +2 Hard +737 −157 updated 02/15/22, 16:40

Commit message

A new "ModuleData" object is introduced, which contains
the allowed module data properties for a module,
overlaid by previously set values from a user.

Each module now has access to this object, as it is
populated during a middleware and the values are persisted.

Review

  • Code review CR +2 Done
    • Oli Bartsch +2
    • Jochen Roth +1
    • Benni Mack +1
  • Verified V +2 Done
    • Oli Bartsch +2
    • Jochen Roth +1
    • Benni Mack +1
    • core-ci +1 CI

Issues 1

Files 28

Show 8 more files

Review log 3555

Show 1530 earlier messages
  1. Benni Mack uploaded patch set 1 02/11/22, 08:05

  2. core-ci voted on patch set 1 V -1 02/11/22, 08:18 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/23363

  3. Benni Mack uploaded patch set 2 02/11/22, 10:19

  4. core-ci voted on patch set 2 V -1 02/11/22, 10:21 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/23371

  5. Benni Mack uploaded patch set 3 02/11/22, 10:23

  6. core-ci voted on patch set 3 V -1 02/11/22, 10:26 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/23373

  7. Benni Mack uploaded patch set 4 02/11/22, 11:30

  8. core-ci voted on patch set 4 V -1 02/11/22, 11:42 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/23377

  9. Benni Mack uploaded patch set 5 02/11/22, 11:46

  10. core-ci voted on patch set 5 V -1 02/11/22, 12:08 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/23380

  11. Benni Mack uploaded patch set 6 02/11/22, 13:07

  12. core-ci voted on patch set 6 V -1 02/11/22, 13:22 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/23391

  13. Oli Bartsch uploaded patch set 7 02/11/22, 21:30

  14. core-ci voted on patch set 7 V +1 02/11/22, 21:40 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/23410

  15. Oli Bartsch uploaded patch set 8 02/11/22, 23:26

  16. core-ci voted on patch set 8 V +1 02/11/22, 23:41 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/23419

  17. Oli Bartsch uploaded patch set 9 02/12/22, 00:05

  18. core-ci voted on patch set 9 V +1 02/12/22, 00:17 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/23420

  19. Oli Bartsch uploaded patch set 10 02/14/22, 19:33

  20. core-ci voted on patch set 10 V -1 02/14/22, 19:44 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/23554

  21. Oli Bartsch uploaded patch set 11 02/14/22, 20:00

  22. core-ci voted on patch set 11 V +1 02/14/22, 20:07 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/23558

  23. Oli Bartsch uploaded patch set 12 02/14/22, 20:32

  24. core-ci voted on patch set 12 V +1 02/14/22, 20:48 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/23564

  25. Oli Bartsch uploaded patch set 13 02/14/22, 21:43

  26. Oli Bartsch uploaded patch set 14 02/14/22, 21:48

  27. core-ci voted on patch set 13 V -1 02/14/22, 21:55 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/23570

  28. core-ci voted on patch set 14 V -1 02/14/22, 21:57 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/23571

  29. Oli Bartsch uploaded patch set 15 02/14/22, 23:38

  30. core-ci voted on patch set 15 V -1 02/14/22, 23:48 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/23582

  1. Oli Bartsch uploaded patch set 16 02/15/22, 00:04

  2. core-ci voted on patch set 16 V +1 02/15/22, 00:13 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/23583

  3. Oli Bartsch uploaded patch set 17 02/15/22, 00:23

  4. core-ci voted on patch set 17 V +1 02/15/22, 00:32 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/23584

  5. Benni Mack voted on patch set 17 V +1 CR +1 02/15/22, 07:26

  6. Jochen Roth commented on patch set 17 02/15/22, 08:52

    PageLayoutController.php:212

    Minor, sounds wird :-) .. value will be allowed in moduleData->cleanUp ..
  7. Oli Bartsch uploaded patch set 18 02/15/22, 11:17

  8. Oli Bartsch commented on patch set 18 02/15/22, 11:17

    PageLayoutController.php:212 Reply

    Done
  9. Benni Mack voted on patch set 18 V +1 CR +1 02/15/22, 11:22

  10. core-ci voted on patch set 18 V +1 02/15/22, 11:27 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/23611

  11. Oli Bartsch uploaded patch set 19 02/15/22, 11:39

  12. Benni Mack voted on patch set 19 V +1 CR +1 02/15/22, 11:42

  13. core-ci voted on patch set 19 V +1 02/15/22, 11:50 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/23614

  14. Christian Kuhn commented on patch set 19 CR -1 02/15/22, 12:13

    didn't test yet, but a couple of minor remarks for now.

    ModuleData.php:21

    please try to improve this content: This DTO is an API to access be-user specific module settings like "is the clipboard shown" and "this sub-view has been selected last". also state this object is available within a request attribute for backend module controllers.

    ModuleDataTest.php:132

    we have the general habit to have data providers *before* the test. is it ok if i request to stick to this?

    Feature-96733-NewBackendModuleRegistrationAPI.rst:174

    this could have some more text: module data are module specific settings per single backend user.

    Feature-96895-IntroduceModuleDataObject.rst:22

    comma too much.

    Feature-96895-IntroduceModuleDataObject.rst:25

    mention that 'module data' are backend user specific settings stored for the backend user accessing the module. maybe add an example like "is the clipboard shown or not?"
  15. Jochen Roth voted on patch set 19 V +1 CR +1 02/15/22, 12:13

  16. Benni Mack commented on patch set 19 V 0 CR 0 02/15/22, 12:34

    good points
  17. Jochen Roth wrote 02/15/22, 12:34

    Removed Verified+1 by Jochen <rothjochen@gmail.com>
  18. Jochen Roth wrote 02/15/22, 12:35

    Removed Code-Review+1 by Jochen <rothjochen@gmail.com>
  19. Oli Bartsch uploaded patch set 20 02/15/22, 14:40

  20. core-ci voted on patch set 20 V +1 02/15/22, 14:50 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/23627

  21. Oli Bartsch commented on patch set 20 02/15/22, 14:51

    ModuleData.php:21 Reply

    Done

    ModuleDataTest.php:132 Reply

    Done

    Feature-96733-NewBackendModuleRegistrationAPI.rst:174 Reply

    Done

    Feature-96895-IntroduceModuleDataObject.rst:22 Reply

    Done

    Feature-96895-IntroduceModuleDataObject.rst:25 Reply

    Done
  22. Benni Mack voted on patch set 20 V +1 CR +1 02/15/22, 14:56

  23. Jochen Roth voted on patch set 20 V +1 CR +1 02/15/22, 15:10

  24. Oli Bartsch voted on patch set 20 V +2 CR +2 02/15/22, 16:40

  25. Oli Bartsch merged patch set 21 02/15/22, 16:40