73415[FEATURE] Unified module data
Commit message
Review
-
Code review CR +2 Done
- Oli Bartsch +2
- Jochen Roth +1
- Benni Mack +1
-
Verified V +2 Done
- Oli Bartsch +2
- Jochen Roth +1
- Benni Mack +1
- core-ci +1 CI
Issues 1
Files 28
- Build/phpstan/phpstan-baseline.neon+0 −5
- Build/Sources/TypeScript/backend/Resources/Public/TypeScript/PageActions.ts+2 −2
- Build/Sources/TypeScript/recordlist/Resources/Public/TypeScript/Recordlist.ts+3 −3
- typo3/sysext/backend/Classes/Controller/PageLayoutController.php2+32 −40
- typo3/sysext/backend/Classes/Middleware/BackendModuleValidator.php+59 −22
- typo3/sysext/backend/Classes/Module/BaseModule.php+10 −0
- typo3/sysext/backend/Classes/Module/MenuModule.php+5 −0
- typo3/sysext/backend/Classes/Module/ModuleData.php2new+124 −0
- typo3/sysext/backend/Classes/Module/ModuleInterface.php+5 −0
- typo3/sysext/backend/Configuration/Backend/Modules.php+5 −0
- typo3/sysext/backend/Resources/Private/Templates/PageLayout/PageModule.html+4 −4
- typo3/sysext/backend/Resources/Public/JavaScript/PageActions.js+1 −1
- typo3/sysext/backend/Tests/Functional/Middleware/BackendModuleValidatorTest.php+37 −4
- typo3/sysext/backend/Tests/Functional/Module/ModuleDataTest.php2new+243 −0
- typo3/sysext/belog/Classes/Controller/BackendLogController.php+3 −3
- typo3/sysext/core/Documentation/Changelog/12.0/Feature-96733-NewBackendModuleRegistrationAPI.rst2+7 −0
- typo3/sysext/core/Documentation/Changelog/12.0/Feature-96895-IntroduceModuleDataObject.rst4new+124 −0
- typo3/sysext/core/Tests/Acceptance/Application/FileList/FileClipboardCest.php+0 −10
- typo3/sysext/filelist/Classes/Controller/FileListController.php+19 −31
- typo3/sysext/filelist/Classes/FileList.php+3 −4
Show 8 more files
- typo3/sysext/filelist/Configuration/Backend/Modules.php+6 −0
- typo3/sysext/fluid/Classes/ViewHelpers/Be/TableListViewHelper.php+11 −0
- typo3/sysext/recordlist/Classes/Browser/DatabaseBrowser.php+5 −0
- typo3/sysext/recordlist/Classes/Controller/RecordListController.php+13 −10
- typo3/sysext/recordlist/Classes/RecordList/DatabaseRecordList.php+5 −15
- typo3/sysext/recordlist/Configuration/Backend/Modules.php+4 −0
- typo3/sysext/recordlist/Resources/Public/JavaScript/Recordlist.js+1 −1
- .phpstorm.meta.php+6 −2
Review log 3555
Show 1530 earlier messages
-
Benni Mack uploaded patch set 1 02/11/22, 08:05
-
core-ci voted on patch set 1 V -1 02/11/22, 08:18 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/23363
-
Benni Mack uploaded patch set 2 02/11/22, 10:19
-
core-ci voted on patch set 2 V -1 02/11/22, 10:21 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/23371
-
Benni Mack uploaded patch set 3 02/11/22, 10:23
-
core-ci voted on patch set 3 V -1 02/11/22, 10:26 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/23373
-
Benni Mack uploaded patch set 4 02/11/22, 11:30
-
core-ci voted on patch set 4 V -1 02/11/22, 11:42 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/23377
-
Benni Mack uploaded patch set 5 02/11/22, 11:46
-
core-ci voted on patch set 5 V -1 02/11/22, 12:08 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/23380
-
Benni Mack uploaded patch set 6 02/11/22, 13:07
-
core-ci voted on patch set 6 V -1 02/11/22, 13:22 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/23391
-
Oli Bartsch uploaded patch set 7 02/11/22, 21:30
-
core-ci voted on patch set 7 V +1 02/11/22, 21:40 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/23410
-
Oli Bartsch uploaded patch set 8 02/11/22, 23:26
-
core-ci voted on patch set 8 V +1 02/11/22, 23:41 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/23419
-
Oli Bartsch uploaded patch set 9 02/12/22, 00:05
-
core-ci voted on patch set 9 V +1 02/12/22, 00:17 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/23420
-
Oli Bartsch uploaded patch set 10 02/14/22, 19:33
-
core-ci voted on patch set 10 V -1 02/14/22, 19:44 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/23554
-
Oli Bartsch uploaded patch set 11 02/14/22, 20:00
-
core-ci voted on patch set 11 V +1 02/14/22, 20:07 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/23558
-
Oli Bartsch uploaded patch set 12 02/14/22, 20:32
-
core-ci voted on patch set 12 V +1 02/14/22, 20:48 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/23564
-
Oli Bartsch uploaded patch set 13 02/14/22, 21:43
-
Oli Bartsch uploaded patch set 14 02/14/22, 21:48
-
core-ci voted on patch set 13 V -1 02/14/22, 21:55 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/23570
-
core-ci voted on patch set 14 V -1 02/14/22, 21:57 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/23571
-
Oli Bartsch uploaded patch set 15 02/14/22, 23:38
-
core-ci voted on patch set 15 V -1 02/14/22, 23:48 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/23582
-
Oli Bartsch uploaded patch set 16 02/15/22, 00:04
-
core-ci voted on patch set 16 V +1 02/15/22, 00:13 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/23583
-
Oli Bartsch uploaded patch set 17 02/15/22, 00:23
-
core-ci voted on patch set 17 V +1 02/15/22, 00:32 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/23584
-
Benni Mack voted on patch set 17 V +1 CR +1 02/15/22, 07:26
-
Jochen Roth commented on patch set 17 02/15/22, 08:52
-
Oli Bartsch uploaded patch set 18 02/15/22, 11:17
-
Oli Bartsch commented on patch set 18 02/15/22, 11:17
PageLayoutController.php:212ReplyDone -
Benni Mack voted on patch set 18 V +1 CR +1 02/15/22, 11:22
-
core-ci voted on patch set 18 V +1 02/15/22, 11:27 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/23611
-
Oli Bartsch uploaded patch set 19 02/15/22, 11:39
-
Benni Mack voted on patch set 19 V +1 CR +1 02/15/22, 11:42
-
core-ci voted on patch set 19 V +1 02/15/22, 11:50 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/23614
-
Christian Kuhn commented on patch set 19 CR -1 02/15/22, 12:13
didn't test yet, but a couple of minor remarks for now.ModuleData.php:21please try to improve this content: This DTO is an API to access be-user specific module settings like "is the clipboard shown" and "this sub-view has been selected last". also state this object is available within a request attribute for backend module controllers.ModuleDataTest.php:132we have the general habit to have data providers *before* the test. is it ok if i request to stick to this?Feature-96733-NewBackendModuleRegistrationAPI.rst:174this could have some more text: module data are module specific settings per single backend user.Feature-96895-IntroduceModuleDataObject.rst:22comma too much.Feature-96895-IntroduceModuleDataObject.rst:25mention that 'module data' are backend user specific settings stored for the backend user accessing the module. maybe add an example like "is the clipboard shown or not?" -
Jochen Roth voted on patch set 19 V +1 CR +1 02/15/22, 12:13
-
Benni Mack commented on patch set 19 V 0 CR 0 02/15/22, 12:34
good points -
Jochen Roth wrote 02/15/22, 12:34
Removed Verified+1 by Jochen <rothjochen@gmail.com> -
Jochen Roth wrote 02/15/22, 12:35
Removed Code-Review+1 by Jochen <rothjochen@gmail.com> -
Oli Bartsch uploaded patch set 20 02/15/22, 14:40
-
core-ci voted on patch set 20 V +1 02/15/22, 14:50 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/23627
-
Oli Bartsch commented on patch set 20 02/15/22, 14:51
ModuleData.php:21ReplyDoneModuleDataTest.php:132ReplyDoneFeature-96733-NewBackendModuleRegistrationAPI.rst:174ReplyDoneFeature-96895-IntroduceModuleDataObject.rst:22ReplyDoneFeature-96895-IntroduceModuleDataObject.rst:25ReplyDone -
Benni Mack voted on patch set 20 V +1 CR +1 02/15/22, 14:56
-
Jochen Roth voted on patch set 20 V +1 CR +1 02/15/22, 15:10
-
Oli Bartsch voted on patch set 20 V +2 CR +2 02/15/22, 16:40
-
Oli Bartsch merged patch set 21 02/15/22, 16:40
PageLayoutController.php:212