Review main Merged

73418[TASK] Clean up various options in UserAuthentication

Benni Mack CR +2 V +2 Easy +11 −31 updated 02/11/22, 13:08

Commit message

This change adapts some comments
and makes the usage of "uc" clearer in various
places.

In addition, one change is removed where the session
data was checked against a non-hashed identifier, which
can now safely be removed in TYPO3 v12.0.

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Oli Bartsch +1
    • Benni Mack +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Oli Bartsch +1
    • Benni Mack +1
    • core-ci +1 CI

Issues 1

Files 5

Review log 811

  1. Benni Mack uploaded patch set 1 02/11/22, 10:00

  2. Benni Mack updated the commit message in patch set 2 02/11/22, 10:02

  3. core-ci voted on patch set 1 V -1 02/11/22, 10:13 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/23368

  4. core-ci voted on patch set 2 V -1 02/11/22, 10:13 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/23369

  5. Oli Bartsch uploaded patch set 3 02/11/22, 10:45

  6. Benni Mack voted on patch set 3 V +1 CR +1 02/11/22, 10:47

  7. core-ci voted on patch set 3 V +1 02/11/22, 10:57 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/23376

  8. Oli Bartsch voted on patch set 3 V +1 CR +1 02/11/22, 11:48

  9. Christian Kuhn commented on patch set 3 CR -1 02/11/22, 12:56

    on it.
  10. Christian Kuhn voted on patch set 3 V +2 CR +2 02/11/22, 13:07

  11. Christian Kuhn merged patch set 4 02/11/22, 13:08