Review main Merged

73421[TASK] Remove obsolete FormInlineAjaxController method

Christian Kuhn CR +2 V +2 Easy +0 −18 updated 02/11/22, 12:58

Commit message

Protected controller method getErrorMessageForAJAX() is
unused since v7 and can be safely removed.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Oli Bartsch +1
    • Oliver Hader +1
  • Verified V +2 Done
    • Benni Mack +2
    • Oli Bartsch +1
    • Oliver Hader +1
    • core-ci +1 CI

Issues 1

Files 1

Review log 89

  1. Christian Kuhn uploaded patch set 1 02/11/22, 10:39

  2. Oliver Hader voted on patch set 1 V +1 CR +1 02/11/22, 10:49

  3. Christian Kuhn rebased onto patch set 2 02/11/22, 12:38

  4. Christian Kuhn commented on patch set 2 02/11/22, 12:38

    seems the CI trigger call got lost here somehow. rebased to re-trigger.
  5. core-ci voted on patch set 2 V +1 02/11/22, 12:49 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/23388

  6. Oliver Hader voted on patch set 2 V +1 CR +1 02/11/22, 12:57

  7. Benni Mack voted on patch set 2 V +2 CR +2 02/11/22, 12:58

  8. Oli Bartsch voted on patch set 2 V +1 CR +1 02/11/22, 12:58

  9. Benni Mack merged patch set 3 02/11/22, 12:58