Review main Merged

73422[BUGFIX] Prevent application type exception in ViewHelper

Oli Bartsch CR +2 V +2 Easy +5 −1 updated 02/11/22, 13:32

Commit message

In case the "f:format.html" ViewHelper is called
in the install tool or via CLI, there might be either
no request object or one without an application
type. This led to an exception on checking the
application type.

This is now fixed by checking the request before
calling the static ApplicationType check.

Review

  • Code review CR +2 Done
    • Oli Bartsch +2
    • Stefan Bürk +1
    • Christian Kuhn +1
  • Verified V +2 Done
    • Oli Bartsch +2
    • Stefan Bürk +1
    • Christian Kuhn +1
    • core-ci +1 CI

Issues 1

Files 1

Review log 68

  1. Oli Bartsch uploaded patch set 1 02/11/22, 11:43

  2. core-ci voted on patch set 1 V -1 02/11/22, 12:02 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/23378

  3. Oli Bartsch uploaded patch set 2 02/11/22, 12:28

  4. core-ci voted on patch set 2 V +1 02/11/22, 12:38 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/23386

  5. Christian Kuhn commented on patch set 2 V +1 CR +1 02/11/22, 12:55

    note we are aware this is a semi-cool solution. main target of this patch is v11, though. for v12 analysis and further patches, see my comment https://forge.typo3.org/issues/96788#note-5 .
  6. Stefan Bürk voted on patch set 2 V +1 CR +1 02/11/22, 13:28

  7. Oli Bartsch voted on patch set 2 V +2 CR +2 02/11/22, 13:32

  8. Oli Bartsch merged patch set 3 02/11/22, 13:32