73423[BUGFIX] Prevent application type exception in ViewHelper
Commit message
Review
-
Code review CR +2 Done
- Oli Bartsch +2
- Stefan Bürk +1
- Christian Kuhn +1
-
Verified V +2 Done
- Oli Bartsch +2
- Stefan Bürk +1
- Christian Kuhn +1
- core-ci +1 CI
Issues 1
Files 1
Review log 1114
-
Oli Bartsch uploaded patch set 1 02/11/22, 11:47
-
Oliver Klee commented on patch set 1 02/11/22, 11:48
-
core-ci voted on patch set 1 V -1 02/11/22, 12:08 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/23382
-
Oli Bartsch uploaded patch set 2 02/11/22, 12:29
-
Oli Bartsch commented on patch set 2 02/11/22, 12:31
HtmlViewHelper.php:114ReplyThis check was superfluous because getRequest only returns the Request object. I however changed it for the main patch, since the getRequest method differs there. -
core-ci voted on patch set 2 V +1 02/11/22, 12:42 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/23387
-
Oliver Klee commented on patch set 2 02/11/22, 13:23
HtmlViewHelper.php:114ReplyAh, I see. Then the commit message probably needs to be adapted to match as well, I think. -
Oli Bartsch updated the commit message in patch set 3 02/11/22, 13:57
-
Oli Bartsch commented on patch set 3 02/11/22, 13:57
HtmlViewHelper.php:114ReplyDone -
Stefan Bürk voted on patch set 3 V +1 CR +1 02/11/22, 13:59
-
Christian Kuhn voted on patch set 3 V +1 CR +1 02/11/22, 14:02
-
Oli Bartsch voted on patch set 3 V +2 CR +2 02/11/22, 14:02
-
core-ci voted on patch set 3 V +1 02/11/22, 14:09 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/23396
-
Oli Bartsch merged patch set 4 02/11/22, 14:13
HtmlViewHelper.php:114