Review 11.5 Merged

73423[BUGFIX] Prevent application type exception in ViewHelper

Oli Bartsch CR +2 V +2 Easy +3 −1 updated 02/11/22, 14:13

Commit message

In case the "f:format.html" ViewHelper is called
in the install tool or via CLI, the request might
miss the application type attribute. This led to
an exception on checking the application type.

This is now fixed by checking the request before
calling the static ApplicationType check.

Review

  • Code review CR +2 Done
    • Oli Bartsch +2
    • Stefan Bürk +1
    • Christian Kuhn +1
  • Verified V +2 Done
    • Oli Bartsch +2
    • Stefan Bürk +1
    • Christian Kuhn +1
    • core-ci +1 CI

Issues 1

Files 1

Review log 1114

  1. Oli Bartsch uploaded patch set 1 02/11/22, 11:47

  2. Oliver Klee commented on patch set 1 02/11/22, 11:48

    HtmlViewHelper.php:114

    To make this check explicit to the reader, I propose using an instanceof check instead.
  3. core-ci voted on patch set 1 V -1 02/11/22, 12:08 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/23382

  4. Oli Bartsch uploaded patch set 2 02/11/22, 12:29

  5. Oli Bartsch commented on patch set 2 02/11/22, 12:31

    HtmlViewHelper.php:114 Reply

    This check was superfluous because getRequest only returns the Request object. I however changed it for the main patch, since the getRequest method differs there.
  6. core-ci voted on patch set 2 V +1 02/11/22, 12:42 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/23387

  7. Oliver Klee commented on patch set 2 02/11/22, 13:23

    HtmlViewHelper.php:114 Reply

    Ah, I see. Then the commit message probably needs to be adapted to match as well, I think.
  8. Oli Bartsch updated the commit message in patch set 3 02/11/22, 13:57

  9. Oli Bartsch commented on patch set 3 02/11/22, 13:57

    HtmlViewHelper.php:114 Reply

    Done
  10. Stefan Bürk voted on patch set 3 V +1 CR +1 02/11/22, 13:59

  11. Christian Kuhn voted on patch set 3 V +1 CR +1 02/11/22, 14:02

  12. Oli Bartsch voted on patch set 3 V +2 CR +2 02/11/22, 14:02

  13. core-ci voted on patch set 3 V +1 02/11/22, 14:09 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/23396

  14. Oli Bartsch merged patch set 4 02/11/22, 14:13