Review main Merged Breaking

73424[!!!][TASK] Remove CSP violating BU::getFuncInput()

Christian Kuhn CR +2 V +2 Normal +47 −27 updated 02/11/22, 13:17

Commit message

BackendUtility::getFuncInput() is a (core) unused
utility method that violates Content-Security-Policy
headers due to onclick attribute. It is of very
limited help anyways and should be removed.

Review

  • Code review CR +2 Done
    • Oli Bartsch +2
    • Stefan Bürk +1
    • Oliver Hader +1
    • Benni Mack +1
  • Verified V +2 Done
    • Oli Bartsch +2
    • Stefan Bürk +1
    • Benni Mack +1
    • core-ci +1 CI

Issues 1

Files 3

Review log 67

  1. Christian Kuhn uploaded patch set 1 02/11/22, 12:08

  2. core-ci voted on patch set 1 V +1 02/11/22, 12:24 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/23383

  3. Benni Mack voted on patch set 1 V +1 CR +1 02/11/22, 13:00

  4. Stefan Bürk voted on patch set 1 V +1 CR +1 02/11/22, 13:07

  5. Oli Bartsch voted on patch set 1 V +2 CR +2 02/11/22, 13:09

  6. Oli Bartsch merged patch set 2 02/11/22, 13:09

  7. Oliver Hader voted on patch set 2 CR +1 02/11/22, 13:17