Review main Merged Breaking

73425[!!!][TASK] Enforce HTML sanitizer during frontend rendering

Oliver Hader CR +2 V +2 Hard +384 −545 updated 02/14/22, 18:59

Commit message

This change drops the fall-back behavior of `parseFunc.htmlSanitize` and
drops the feature flag `security.frontend.htmlSanitizeParseFuncDefault`.
Both were introduced as a follow-up to TYPO3-CORE-SA-2021-013, to relax
HTML sanitization for a temporary migration period.

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Benni Mack +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Benni Mack +1
    • core-ci +1 CI

Issues 1

Files 7

Review log 811

  1. Oliver Hader uploaded patch set 1 02/11/22, 12:53

  2. core-ci voted on patch set 1 V -1 02/11/22, 13:04 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/23390

  3. Oliver Hader uploaded patch set 2 02/11/22, 13:10

  4. Benni Mack commented on patch set 2 02/11/22, 13:15

    DefaultConfiguration.php:76

    you can put this in the Features class so 3rd party extensions which use the Features API will know it's now "always on"
  5. core-ci voted on patch set 2 V +1 02/11/22, 13:22 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/23392

  6. Benni Mack uploaded patch set 3 02/14/22, 09:01

  7. Benni Mack voted on patch set 3 V +1 CR +1 02/14/22, 09:01

  8. Benni Mack commented on patch set 3 02/14/22, 09:01

    DefaultConfiguration.php:76 Reply

    Done
  9. core-ci voted on patch set 3 V +1 02/14/22, 09:14 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/23493

  10. Christian Kuhn voted on patch set 3 V +2 CR +2 02/14/22, 18:58

  11. Christian Kuhn merged patch set 4 02/14/22, 18:59