Review main Merged

73428[TASK] Raise doctrine/dbal:^3.3.2

Stefan Bürk CR +2 V +2 Normal +98 −98 updated 02/15/22, 19:07

Commit message

Raising doctrine/dbal to have "latest" deprecations
in place. This gives us the posiblity to analyse and
implement the needed adoptions to the public provided
core fascade classes and analysing further which may
be needed to change in preparation for upcomming
"doctrine/dbal":"^4.x" and how we will handle this.

used commands:

> composer req doctrine/dbal:^3.3.2 -W
> composer req doctrine/dbal:^3.3.2 \
  -d typo3/sysext/core --no-update
> composer req doctrine/dbal:^3.3.2 \
  -d typo3/sysext/redirects --no-update
> composer req doctrine/dbal:^3.3.2 \
  -d typo3/sysext/install --no-update

Review

  • Code review CR +2 Done
    • Georg Ringer +2
    • Oli Bartsch +1
    • Benni Mack +1
  • Verified V +2 Done
    • Georg Ringer +2
    • Oli Bartsch +1
    • Benni Mack +1
    • core-ci +1 CI

Issues 1

Files 5

Review log 1014

  1. Stefan Bürk uploaded patch set 1 02/11/22, 14:10

  2. core-ci voted on patch set 1 V +1 02/11/22, 14:19 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/23398

  3. Stefan Bürk updated the commit message in patch set 2 02/11/22, 14:39

  4. core-ci voted on patch set 2 V +1 02/11/22, 14:54 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/23400

  5. Benni Mack commented on patch set 2 02/11/22, 15:19

    Try "composer req doctrine/dbal:^3.3.2 -W"
  6. Stefan Bürk uploaded patch set 3 02/11/22, 16:31

  7. Stefan Bürk commented on patch set 3 02/11/22, 16:32

    Reply

    Done. We will see. Thanks.
  8. core-ci voted on patch set 3 V +1 02/11/22, 16:40 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/23405

  9. Stefan Bürk uploaded patch set 4 02/15/22, 16:18

  10. core-ci voted on patch set 4 V +1 02/15/22, 16:31 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/23637

  11. Benni Mack voted on patch set 4 V +1 CR +1 02/15/22, 16:44

  12. Oli Bartsch voted on patch set 4 V +1 CR +1 02/15/22, 17:07

  13. Georg Ringer voted on patch set 4 V +2 CR +2 02/15/22, 19:07

  14. Georg Ringer merged patch set 5 02/15/22, 19:07