Review main Merged

73433[BUGFIX] Ignore deleted l10n_source records when translating

Susi Moog CR +2 V +2 Easy +32 −5 updated 02/15/22, 11:24

Commit message

If l10n_source points to a deleted or non-existing record the
translation wizard failed in free mode with a 500 error,
because determining the source languages fail and no fallback was
implemented. Instead of failing, the behaviour was adjusted to
handle l10n_source pointing to erroneous records similarly to an
empty column and offering all available language as option for
the translation - as in fact the source cannot be reliably determined.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Jörg Bösche +1
  • Verified V +2 Done
    • Benni Mack +2
    • Jörg Bösche +1
    • core-ci +1 CI

Issues 1

Files 4

Review log 1214

  1. Susi Moog uploaded patch set 1 02/11/22, 18:51

  2. Christian Kuhn commented on patch set 1 02/11/22, 18:54

    please please please: avoid .xml fixtures in functionals ... we're in the process of transitioning all of these to .csv imports (which nowadays resolve paths just fine for phpstorm) and would love to deprecate .xml fixtures entirely. benni had 2 patches to ditch .xml already ;)
  3. Christian Kuhn commented on patch set 1 02/11/22, 18:56

    Reply

    note: use "Build/Scripts/runTests.sh -s fixCsvFixtures" to avoid headaches with commata shit for csv ;)
  4. Susi Moog commented on patch set 1 02/11/22, 18:58

    Reply

    The Fixtures "next to these" are xml - I tried to stay consistent, should I a) change all of them b) add the new ones as CSV and mixing formats c) run around in circles and be confused ;)
  5. core-ci voted on patch set 1 V +1 02/11/22, 19:00 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/23408

  6. Christian Kuhn commented on patch set 1 02/11/22, 19:04

    Reply

    imho: mix it, or have a pre-patch to fix others first (ideal ... more work for you now, less work for benni/me later :P) you'll hopefully find that recent importCSVDataSet() is so much more elegant in all regards that you want to move away from xml to csv all day ^^
  7. Christian Kuhn commented on patch set 1 02/11/22, 19:06

    Reply

    i can of course live with the 'mix' approach. we'll have to have some systematic work to eradicate .xml anyways, so it does not matter much if you mix it now. i just want to avoid 'more work' ;)
  8. Susi Moog uploaded patch set 2 02/11/22, 19:13

  9. Susi Moog commented on patch set 2 02/11/22, 19:15

    Reply

    👍 CSVed it. Will hopefully do the "post-patch" tomorrow.
  10. Jörg Bösche voted on patch set 2 CR +1 02/11/22, 19:18

  11. core-ci voted on patch set 2 V +1 02/11/22, 19:22 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/23409

  12. Jörg Bösche voted on patch set 2 V +1 02/11/22, 19:32

  13. Benni Mack voted on patch set 2 V +2 CR +2 02/15/22, 11:24

  14. Benni Mack merged patch set 3 02/15/22, 11:24