Review main Merged

73436[TASK] gitlab-ci: Merge 'early' state into 'main'

Christian Kuhn CR +2 V +2 Easy +12 −28 updated 02/12/22, 13:19

Commit message

Casual "pre-merge" patches (pushing a patch) to CI
gives us two stages: An "early" stage checking CGL
and composer basics, plus the "main" stage checking
everything else.

The goal with this approach is to return early on
simple errors like CGL violations without wasting
additional ressources on other things when those
pre-conditions fail.

In practice, an early "cgl broken" pipeline shadowes
possible further issues and extends runtime of
single builds since 'main' is only run after 'early'
has been successful.

The patch merges all "pre-merge" jobs into one
stage. This means more jobs are executed in parallel,
but we hope the infrastructure can cope with that.
If that works out, CI should answer more quickly
on single patches.

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Stefan Bürk +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Stefan Bürk +1
    • core-ci +1 CI

Issues 1

Files 4

Review log 1522

  1. Christian Kuhn uploaded patch set 1 02/11/22, 22:34

  2. Christian Kuhn updated the commit message in patch set 2 02/11/22, 22:36

  3. Christian Kuhn commented on patch set 2 CR -1 02/11/22, 22:41

    need opinion by stefan on this one.
  4. core-ci voted on patch set 2 V +1 02/11/22, 22:46 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/23417

  5. core-ci voted on patch set 1 V +1 02/11/22, 22:46 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/23416

  6. Christian Kuhn commented on patch set 2 02/11/22, 22:56

    will adapt the file paths in case we think this in good..
  7. Anja Leichsenring updated the commit message in patch set 3 02/12/22, 09:24

  8. core-ci voted on patch set 3 V +1 02/12/22, 09:38 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/23439

  9. Christian Kuhn updated the commit message in patch set 4 02/12/22, 11:07

  10. Christian Kuhn voted on patch set 4 CR -1 02/12/22, 11:16

  11. core-ci voted on patch set 4 V +1 02/12/22, 11:18 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/23443

  12. Stefan Bürk commented on patch set 4 02/12/22, 11:43

    Reply

    I think this is good tradeoff. In general the basic cgl should be found by the pre-commit hook mentioned in the contribution guide. And having to round trips is more annoying then knowing that there are cgl AND real issues. CI infrastructure should cope with it. So I would give this a try, but I'm confident that this pays out. Just let us move the early.yml entries to main.yml.
  13. Christian Kuhn uploaded patch set 5 02/12/22, 12:55

  14. Stefan Bürk voted on patch set 5 V +1 CR +1 02/12/22, 13:02

  15. Christian Kuhn uploaded patch set 6 02/12/22, 13:02

  16. core-ci voted on patch set 6 V -1 02/12/22, 13:03 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/23449

  17. Christian Kuhn uploaded patch set 7 02/12/22, 13:06

  18. core-ci voted on patch set 5 V +1 02/12/22, 13:09 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/23448

  19. core-ci voted on patch set 7 V +1 02/12/22, 13:13 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/23450

  20. Stefan Bürk voted on patch set 7 V +1 CR +1 02/12/22, 13:15

  21. Christian Kuhn commented on patch set 7 V +2 CR +2 02/12/22, 13:19

    i'll take the freedom to merge this since it's strictly CI related only. we'll monitor CI behavior to see if it works out as expected.
  22. Christian Kuhn merged patch set 8 02/12/22, 13:19