Review main Merged

73438[TASK] Declare ShowImageController ext:frontend as strict typed

Anja Leichsenring CR +2 V +2 Easy +2 −0 updated 02/18/22, 16:07

Commit message

Review

  • Code review CR +2 Done
    • Benjamin Franzke +2
    • Benni Mack +1
  • Verified V +2 Done
    • Benjamin Franzke +2
    • Benni Mack +1
    • core-ci +1 CI

Issues 1

Files 1

Review log 1420

  1. Anja Leichsenring uploaded patch set 1 02/12/22, 08:24

  2. Anja Leichsenring uploaded patch set 2 02/12/22, 08:55

  3. core-ci voted on patch set 2 V -1 02/12/22, 09:04 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/23432

  4. Anja Leichsenring uploaded patch set 3 02/12/22, 09:09

  5. core-ci voted on patch set 3 V +1 02/12/22, 09:19 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/23434

  6. Nikita Hovratov voted on patch set 3 V +1 CR +1 02/12/22, 10:06

  7. core-ci voted on patch set 1 V -1 02/12/22, 10:26 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/23425

  8. Christian Kuhn commented on patch set 3 02/12/22, 12:31

    unsure with TSFE ... this could become tricky and needs proper testing. As such, I'll not just merge this now and would love to see some more testers on this.
  9. Oliver Klee voted on patch set 3 CR +1 02/12/22, 12:40

  10. Christian Kuhn commented on patch set 3 CR -1 02/12/22, 12:45

    maybe we should leave out FE related controllers for now and make testing-framework more strict, first, since that will probably find a bunch of FE related issues.
  11. Benni Mack commented on patch set 4 02/16/22, 21:07

    Published edit on patch set 3.
  12. Benni Mack updated the commit message in patch set 5 02/16/22, 21:07

  13. Christian Kuhn rebased onto patch set 6 02/16/22, 21:15

  14. core-ci voted on patch set 6 V +1 02/16/22, 21:30 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/23755

  15. core-ci voted on patch set 5 V +1 02/16/22, 21:31 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/23753

  16. core-ci voted on patch set 4 V -1 02/16/22, 21:32 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/23752

  17. Benni Mack voted on patch set 6 V +1 CR +1 02/17/22, 23:19

  18. Benjamin Franzke commented on patch set 6 V -1 02/18/22, 07:13

    Currently not testable due to ShowImageController (tx_cms_showpic) always producing 404 errors due to a PHP 8.1 in StoragePermissionAspect warning that is catched by the controller. So we need to handle that first: https://forge.typo3.org/issues/96960 https://review.typo3.org/c/Packages/TYPO3.CMS/+/73597
  19. Benjamin Franzke commented on patch set 6 V +2 CR +2 02/18/22, 16:07

    the fix is merged, this patch is fine now.
  20. Benjamin Franzke merged patch set 7 02/18/22, 16:07