Review main Merged

73439[TASK] Declare controllers of ext:indexed_search as strict

Anja Leichsenring CR +2 V +2 Easy +5 −1 updated 08/12/22, 18:10

Commit message

Set controllers to declare(strict_types=1);

Review

  • Code review CR +2 Done
    • Stefan Bürk +2
    • Christian Kuhn +1
  • Verified V +2 Done
    • Stefan Bürk +2
    • Christian Kuhn +1
    • core-ci +1 CI

Issues 1

Files 2

Review log 1722

  1. Anja Leichsenring uploaded patch set 1 02/12/22, 08:27

  2. core-ci voted on patch set 1 V +1 02/12/22, 08:39 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/23426

  3. Nikita Hovratov voted on patch set 1 V +1 CR +1 02/12/22, 09:56

  4. Oliver Klee voted on patch set 1 CR +1 02/12/22, 10:47

  5. Christian Kuhn commented on patch set 1 V -1 02/12/22, 12:29

    frontend upon submitting a search word: "md5(): Argument #1 ($string) must be of type string, int given"
  6. Christian Kuhn commented on patch set 1 02/12/22, 12:45

    maybe we should leave out FE related controllers for now and make testing-framework more strict, first, since that will probably find a bunch of FE related issues. sidenote: the fact that CI is happy with this patch means that indexed_search has no proper AC test coverage in FE.
  7. Anja Leichsenring commented on patch set 1 06/17/22, 08:51

    Reply

    do you think we can reconsider the patch? TF is strict now.
  8. Anja Leichsenring rebased onto patch set 2 06/17/22, 08:51

  9. Oliver Klee voted on patch set 2 CR +1 06/17/22, 08:53

  10. core-ci voted on patch set 2 V +1 06/17/22, 08:59 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/28132

  11. Oliver Klee voted on patch set 2 CR 0 06/17/22, 09:04

  12. Oliver Klee commented on patch set 2 06/17/22, 09:39

    I think we need to sift through these two classes, look for PHP functions that take strings, and add string casts to the arguments that cannot be ensured to be strings.
  13. Stefan Bürk rebased onto patch set 3 07/08/22, 21:17

  14. core-ci voted on patch set 3 V +1 07/08/22, 21:25 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/28782

  15. Anja Leichsenring rebased onto patch set 4 08/12/22, 17:46

  16. core-ci voted on patch set 4 V +1 08/12/22, 17:53 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/30108

  17. Christian Kuhn uploaded patch set 5 08/12/22, 17:57

  18. core-ci voted on patch set 5 V +1 08/12/22, 18:04 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/30110

  19. Stefan Bürk voted on patch set 5 V +1 CR +1 08/12/22, 18:07

  20. Christian Kuhn voted on patch set 5 V +1 CR +1 08/12/22, 18:09

  21. Stefan Bürk voted on patch set 5 V +2 CR +2 08/12/22, 18:10

  22. Stefan Bürk merged patch set 6 08/12/22, 18:10