Review main Merged

73443[TASK] Declare all controllers of ext:setup as strict typed

Anja Leichsenring CR +2 V +2 Easy +3 −1 updated 02/12/22, 12:02

Commit message

Set all missing files to declare(strict_types=1);

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Oliver Klee +1
    • Nikita Hovratov +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Nikita Hovratov +1
    • core-ci +1 CI

Issues 1

Files 1

Review log 68

  1. Anja Leichsenring uploaded patch set 1 02/12/22, 08:37

  2. core-ci voted on patch set 1 V -1 02/12/22, 08:54 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/23430

  3. Anja Leichsenring uploaded patch set 2 02/12/22, 09:05

  4. core-ci voted on patch set 2 V +1 02/12/22, 09:14 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/23433

  5. Nikita Hovratov voted on patch set 2 V +1 CR +1 02/12/22, 10:02

  6. Oliver Klee voted on patch set 2 CR +1 02/12/22, 10:47

  7. Christian Kuhn voted on patch set 2 V +2 CR +2 02/12/22, 12:01

  8. Christian Kuhn merged patch set 3 02/12/22, 12:02