Review main Merged

73444[TASK] Declare all controllers of ext:t3editor as strict typed

Anja Leichsenring CR +2 V +2 Easy +4 −0 updated 03/23/22, 18:33

Commit message

Set all missing files to declare(strict_types=1);

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Oliver Klee +1
    • Nikita Hovratov +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Nikita Hovratov +1
    • core-ci +1 CI

Issues 1

Files 2

Review log 67

  1. Anja Leichsenring uploaded patch set 1 02/12/22, 08:39

  2. core-ci voted on patch set 1 V +1 02/12/22, 08:53 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/23431

  3. Nikita Hovratov voted on patch set 1 V +1 CR +1 02/12/22, 09:58

  4. Oliver Klee voted on patch set 1 CR +1 02/12/22, 10:47

  5. Christian Kuhn voted on patch set 1 V +2 CR +2 02/12/22, 12:20

  6. Christian Kuhn merged patch set 2 02/12/22, 12:20

  7. Benjamin Franzke commented on patch set 2 02/17/22, 06:46

    CodeCompletionController.php:3 Unresolved

    Caused an error in my installation, please see following followup: https://forge.typo3.org/issues/96937 https://review.typo3.org/c/Packages/TYPO3.CMS/+/73571