73450[BUGFIX] Avoid always enabled clipboard in RecordListController
Commit message
Review
-
Code review CR +2 Done
- Andreas Kienast +2
- Christian Kuhn +1
-
Verified V +2 Done
- Andreas Kienast +2
- Christian Kuhn +1
- core-ci +1 CI
Issues 2
Files 1
Review log 811
-
Stefan Bürk uploaded patch set 1 02/12/22, 12:15
-
core-ci voted on patch set 1 V +1 02/12/22, 12:25 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/23446
-
Christian Kuhn commented on patch set 1 V -1 02/12/22, 12:36
TYPO3\CMS\Recordlist\Controller\RecordListController::renderToggleClipboardHtml(): Argument #3 ($checked) must be of type bool, string given, called in /var/www/local/coremaster/public/typo3/sysext/recordlist/Classes/Controller/RecordListController.php on line 181 -
Stefan Bürk uploaded patch set 2 02/12/22, 12:47
-
Stefan Bürk commented on patch set 2 02/12/22, 12:48
Reply
Weired. Must be because of recently added `declare(strict_types=1);`. Changed patch to mitigate this. -
core-ci voted on patch set 2 V +1 02/12/22, 12:59 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/23447
-
Stefan Bürk uploaded patch set 3 02/12/22, 13:41
-
Christian Kuhn voted on patch set 3 V +1 CR +1 02/12/22, 13:47
-
core-ci voted on patch set 3 V +1 02/12/22, 13:49 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/23456
-
Andreas Kienast voted on patch set 3 V +2 CR +2 02/12/22, 15:08
-
Andreas Kienast merged patch set 4 02/12/22, 15:08