Review main Merged

73450[BUGFIX] Avoid always enabled clipboard in RecordListController

Stefan Bürk CR +2 V +2 Easy +2 −2 updated 02/12/22, 15:08

Commit message

Streamlining RecordListController with #96784 simplified
determiniation, if clipboard should be displayed or not.
This introduced a bug where it is now always enabled.

This patch changes this simplifying so clipboard can be
controlled over parameters again and is not always shown.

Review

  • Code review CR +2 Done
    • Andreas Kienast +2
    • Christian Kuhn +1
  • Verified V +2 Done
    • Andreas Kienast +2
    • Christian Kuhn +1
    • core-ci +1 CI

Issues 2

Files 1

Review log 811

  1. Stefan Bürk uploaded patch set 1 02/12/22, 12:15

  2. core-ci voted on patch set 1 V +1 02/12/22, 12:25 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/23446

  3. Christian Kuhn commented on patch set 1 V -1 02/12/22, 12:36

    TYPO3\CMS\Recordlist\Controller\RecordListController::renderToggleClipboardHtml(): Argument #3 ($checked) must be of type bool, string given, called in /var/www/local/coremaster/public/typo3/sysext/recordlist/Classes/Controller/RecordListController.php on line 181
  4. Stefan Bürk uploaded patch set 2 02/12/22, 12:47

  5. Stefan Bürk commented on patch set 2 02/12/22, 12:48

    Reply

    Weired. Must be because of recently added `declare(strict_types=1);`. Changed patch to mitigate this.
  6. core-ci voted on patch set 2 V +1 02/12/22, 12:59 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/23447

  7. Stefan Bürk uploaded patch set 3 02/12/22, 13:41

  8. Christian Kuhn voted on patch set 3 V +1 CR +1 02/12/22, 13:47

  9. core-ci voted on patch set 3 V +1 02/12/22, 13:49 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/23456

  10. Andreas Kienast voted on patch set 3 V +2 CR +2 02/12/22, 15:08

  11. Andreas Kienast merged patch set 4 02/12/22, 15:08