Review 11.5 Merged

73452[TASK] gitlab-ci: Merge 'early' state into 'main'

Christian Kuhn CR +2 V +2 Easy +12 −28 updated 02/12/22, 13:46

Commit message

Casual "pre-merge" patches (pushing a patch) to CI
gives us two stages: An "early" stage checking CGL
and composer basics, plus the "main" stage checking
everything else.

The goal with this approach is to return early on
simple errors like CGL violations without wasting
additional ressources on other things when those
pre-conditions fail.

In practice, an early "cgl broken" pipeline shadowes
possible further issues and extends runtime of
single builds since 'main' is only run after 'early'
has been successful.

The patch merges all "pre-merge" jobs into one
stage. This means more jobs are executed in parallel,
but we hope the infrastructure can cope with that.
If that works out, CI should answer more quickly
on single patches.

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Stefan Bürk +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Stefan Bürk +1
    • core-ci +1 CI

Issues 1

Files 4

Review log 57

  1. Christian Kuhn uploaded patch set 1 02/12/22, 13:25

  2. core-ci voted on patch set 1 V -1 02/12/22, 13:25 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/23452

  3. Christian Kuhn uploaded patch set 2 02/12/22, 13:26

  4. core-ci voted on patch set 2 V +1 02/12/22, 13:40 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/23453

  5. Stefan Bürk voted on patch set 2 V +1 CR +1 02/12/22, 13:44

  6. Christian Kuhn voted on patch set 2 V +2 CR +2 02/12/22, 13:45

  7. Christian Kuhn merged patch set 3 02/12/22, 13:46