Review main Merged

73454[TASK] Migrate more test fixtures to CSV

Susi Moog CR +2 V +2 Nightmare +1152 −4787 updated 02/14/22, 18:23

Commit message

* Migrate most test fixtures from .xml to .csv.
  Some special cases are left out, those will
  receive dedicated patches.
* Streamline assertCSVDataSet() and
  importCSVDataSet() usage to __DIR__
  relative paths.

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Susi Moog +1
    • Benni Mack +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Susi Moog +1
    • Benni Mack +1
    • core-ci +1 CI

Issues 1

Files 242

Show 222 more files

Review log 1930

Show 35 earlier messages
  1. Susi Moog uploaded patch set 1 02/12/22, 13:51

  2. Benni Mack updated the commit message in patch set 2 02/12/22, 13:56

  3. core-ci voted on patch set 1 V -1 02/12/22, 13:59 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/23457

  4. core-ci voted on patch set 2 V -1 02/12/22, 14:04 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/23458

  5. Susi Moog uploaded patch set 3 02/12/22, 15:05

  1. core-ci voted on patch set 3 V -1 02/12/22, 15:13 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/23459

  2. Susi Moog uploaded patch set 4 02/12/22, 16:51

  3. core-ci voted on patch set 4 V -1 02/12/22, 17:03 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/23463

  4. Benni Mack commented on patch set 4 02/14/22, 09:43

    just leave out recycler for the time being
  5. Christian Kuhn commented on patch set 4 CR -1 02/14/22, 12:04

    on it. let's see if we can finish this beast before we're facing merge conflicts ;)
  6. Christian Kuhn uploaded patch set 5 02/14/22, 14:21

  7. core-ci voted on patch set 5 V -1 02/14/22, 14:31 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/23518

  8. Christian Kuhn uploaded patch set 6 02/14/22, 14:51

  9. Christian Kuhn commented on patch set 6 02/14/22, 14:51

    green except postgres functionals - various fields need a value when they're in the data set ... this will need some further manual work i suppose.
  10. core-ci voted on patch set 6 V -1 02/14/22, 15:04 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/23521

  11. Christian Kuhn uploaded patch set 7 02/14/22, 15:05

  12. core-ci voted on patch set 7 V -1 02/14/22, 15:17 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/23523

  13. Christian Kuhn uploaded patch set 8 02/14/22, 17:00

  14. Christian Kuhn uploaded patch set 9 02/14/22, 17:06

  15. core-ci voted on patch set 8 V -1 02/14/22, 17:12 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/23536

  16. core-ci voted on patch set 9 V -1 02/14/22, 17:17 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/23537

  17. Christian Kuhn uploaded patch set 10 02/14/22, 17:22

  18. core-ci voted on patch set 10 V -1 02/14/22, 17:32 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/23538

  19. Christian Kuhn uploaded patch set 11 02/14/22, 17:40

  20. core-ci voted on patch set 11 V +1 02/14/22, 17:55 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/23542

  21. Benni Mack voted on patch set 11 V +1 CR +1 02/14/22, 18:10

  22. Christian Kuhn voted on patch set 11 V +1 CR +1 02/14/22, 18:20

  23. Susi Moog voted on patch set 11 V +1 CR +1 02/14/22, 18:21

  24. Christian Kuhn voted on patch set 11 V +2 CR +2 02/14/22, 18:22

  25. Christian Kuhn merged patch set 12 02/14/22, 18:23