Review main Merged

73455[TASK] Migrate Backend/Tabs module to native JS

Andreas Kienast CR +2 V +2 Normal +29 −38 updated 02/14/22, 09:58

Commit message

The module Backend/Tabs used for advanced tab handling now doesn't use
jQuery anymore.

Additionally, the following changes were made:

* removed unused method `getTimestamp()`
* removed global tab state persistence state
* only register event listener if tab state should be saved

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Oli Bartsch +1
    • Benni Mack +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Oli Bartsch +1
    • core-ci +1 CI

Issues 1

Files 2

Review log 68

  1. Andreas Kienast uploaded patch set 1 02/12/22, 16:21

  2. Andreas Kienast updated the commit message in patch set 2 02/12/22, 16:23

  3. core-ci voted on patch set 1 V +1 02/12/22, 16:32 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/23460

  4. core-ci voted on patch set 2 V +1 02/12/22, 16:33 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/23461

  5. Benni Mack commented on patch set 2 CR +1 02/12/22, 17:11

    nice one!
  6. Oli Bartsch voted on patch set 2 V +1 CR +1 02/14/22, 09:35

  7. Christian Kuhn voted on patch set 2 V +2 CR +2 02/14/22, 09:58

  8. Christian Kuhn merged patch set 3 02/14/22, 09:58